* [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1
@ 2023-08-09 17:15 Oswald Buddenhagen
2023-08-09 19:43 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Oswald Buddenhagen @ 2023-08-09 17:15 UTC (permalink / raw
To: git; +Cc: Junio C Hamano
This was added by 3ece9bf0f9 (send-email: clear the $message_id after
validation, 2023-05-17) for no apparent reason, as this is required only
in cases when git's stdin is (must be) redirected, which isn't the case
here.
Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
---
Cc: Junio C Hamano <gitster@pobox.com>
---
t/t9001-send-email.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 48bf0af2ee..c445859f73 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '
clean_fake_sendmail &&
echo true | write_script my-hooks/sendemail-validate &&
test_config core.hooksPath my-hooks &&
- GIT_SEND_EMAIL_NOTTY=1 \
git send-email --validate --to=recipient@example.com \
--smtp-server="$(pwd)/fake.sendmail" \
$patches $threaded_patches &&
--
2.40.0.152.g15d061e6df
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1
2023-08-09 17:15 [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1 Oswald Buddenhagen
@ 2023-08-09 19:43 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2023-08-09 19:43 UTC (permalink / raw
To: Oswald Buddenhagen; +Cc: git
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> This was added by 3ece9bf0f9 (send-email: clear the $message_id after
> validation, 2023-05-17) for no apparent reason, as this is required only
> in cases when git's stdin is (must be) redirected, which isn't the case
> here.
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Good eyes. Thanks, will apply.
>
> ---
> Cc: Junio C Hamano <gitster@pobox.com>
> ---
> t/t9001-send-email.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 48bf0af2ee..c445859f73 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '
> clean_fake_sendmail &&
> echo true | write_script my-hooks/sendemail-validate &&
> test_config core.hooksPath my-hooks &&
> - GIT_SEND_EMAIL_NOTTY=1 \
> git send-email --validate --to=recipient@example.com \
> --smtp-server="$(pwd)/fake.sendmail" \
> $patches $threaded_patches &&
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-09 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-09 17:15 [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1 Oswald Buddenhagen
2023-08-09 19:43 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).