From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B37401F44D for ; Mon, 4 Mar 2024 17:24:33 +0000 (UTC) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 60582B29EBD for ; Mon, 4 Mar 2024 17:22:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AC214604B0; Mon, 4 Mar 2024 17:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="lxLM0wnE" Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F7C3FB02 for ; Mon, 4 Mar 2024 17:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.108.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709572957; cv=none; b=Oddpz35dytIjKG8f4wP3ftXGtc79S7bFl6qitUpPaLdjIDZDPw430rRWgKtmUUZz2evcWwlOtoTy+vPFfXXMCSBd7ECp1eogCrp28pxiAwMUcxEHNpvgqFJJ7oFGEtSQx+BQdZuiURETiopYYhMzIt+5PYuVPD4gBi6U6+G+uzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709572957; c=relaxed/simple; bh=gR9hLn35vuJNIfteWxtTCEnVVczU6slbA+5vFIbkGss=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=EyDYHS+0Yv7sHHK3PrSqGXWjcy8trttCPoB4mnfPmq0k4LGaoqZ4lDUdZ/ZG9R8ztKrBf442E+vdWFallDNmPyzYeBXIKa52qrBFZIuGk5ywC9OUPgClhKpAzAdniC7iFbGHzAcz3qb5HzywnQYlPjyQ2VWGAAgoRe0talXCgfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=lxLM0wnE; arc=none smtp.client-ip=64.147.108.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id A7D491CE701; Mon, 4 Mar 2024 12:22:34 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=gR9hLn35vuJNIfteWxtTCEnVVczU6slbA+5vFI bkGss=; b=lxLM0wnETuUyUcFhx8VYtkogWq+80WZKo/9QiURBLOt8PMQI77fJib jkqIFEy8nBW/G39sWAgiBRyOncFI0d/6BjAY9cmTHd2WizNekXjFDR9hbVvJItWR x+qX6IZruKrwk4bdGeu41XuSSLFfnft/aoBP15AoZDEkyK4q8bLmE= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id A129A1CE6FF; Mon, 4 Mar 2024 12:22:34 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.176.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 1679F1CE6FE; Mon, 4 Mar 2024 12:22:34 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: shejialuo Cc: git@vger.kernel.org, Eric Sunshine , Patrick Steinhardt Subject: Re: [PATCH v4 1/1] [PATCH] t9117: prefer test_path_* helper functions In-Reply-To: <20240304095436.56399-2-shejialuo@gmail.com> (shejialuo@gmail.com's message of "Mon, 4 Mar 2024 17:54:36 +0800") References: <20240301130334.135773-1-shejialuo@gmail.com> <20240304095436.56399-1-shejialuo@gmail.com> <20240304095436.56399-2-shejialuo@gmail.com> Date: Mon, 04 Mar 2024 09:22:32 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: C9FAE4A4-DA4B-11EE-8730-78DCEB2EC81B-77302942!pb-smtp1.pobox.com shejialuo writes: > test -(e|d) does not provide a nice error message when we hit test > failures, so use test_path_exists, test_path_is_dir instead. OK. > > Signed-off-by: shejialuo > --- Just for the next single-patch topic you'd work on, here below the three-dash line is where you may mention what's different between the previous iteration and this one, if you wanted to, instead of having a separate cover-letter message. > t/t9117-git-svn-init-clone.sh | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) The patch looks good to me. Thanks (and thanks for all the reviewers of the previous rounds).