git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Barret Rennie <barret@brennie.ca>
Cc: git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Michael Rappazzo" <rappazzo@gmail.com>
Subject: Re: [PATCH] builtin/worktree.c: add option for setting worktree name
Date: Fri, 24 Jun 2016 23:17:51 -0700	[thread overview]
Message-ID: <xmqq60sxeqr4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160625051548.95564-1-barret@brennie.ca> (Barret Rennie's message of "Fri, 24 Jun 2016 23:15:48 -0600")

Barret Rennie <barret@brennie.ca> writes:

> Add the --name parameter to git worktree add that allows the user to set
> the name of the created worktree directory. A worktree must not already
> exist with the current name or creation will fail.

Hmph.  This strongly smells like "because we can add this feature",
not "because we need to add this feature".

What problem does it solve?  Please do not give me "currently we
cannot give a name and instead live with the automatically given
one, and with this patch we can give arbitrary name" as the answer.
That is what I called "because we can".  Why is it bad that you have
to live with the name automatically given to your new worktree?

  reply	other threads:[~2016-06-25  6:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-25  5:15 [PATCH] builtin/worktree.c: add option for setting worktree name Barret Rennie
2016-06-25  6:17 ` Junio C Hamano [this message]
2016-06-25  6:28   ` Barret Rennie
2016-06-25  7:15 ` Johannes Sixt
2016-06-25  7:29   ` Barret Rennie
2016-06-25  7:29   ` Barret Rennie
2016-06-25 19:45     ` Junio C Hamano
2016-06-25 20:19       ` Barret Rennie
2016-06-26 18:15       ` Junio C Hamano
2016-06-27  5:40         ` Barret Rennie
2016-06-27 13:17           ` Junio C Hamano
2016-06-26 23:00       ` Eric Sunshine
2016-06-27  5:52         ` Barret Rennie
2016-06-27 23:11           ` Eric Sunshine
2016-06-29  4:45             ` Barret Rennie
2016-06-25  7:32   ` Barret Rennie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq60sxeqr4.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=barret@brennie.ca \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=rappazzo@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).