From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Leho Kraav" <leho@conversionready.com>,
git@vger.kernel.org
Subject: Re: [PATCHv2 7/7] versioncmp: generalize version sort suffix reordering
Date: Thu, 08 Dec 2016 11:36:57 -0800 [thread overview]
Message-ID: <xmqq60mutdpi.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161208142401.1329-8-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Thu, 8 Dec 2016 15:24:01 +0100")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> The 'versionsort.prereleaseSuffix' configuration variable, as its name
> suggests, is supposed to only deal with tagnames with prerelease
> suffixes, and allows sorting those prerelease tags in a user-defined
> order before the suffixless main release tag, instead of sorting them
> simply lexicographically.
>
> However, the previous changes in this series resulted in an
> interesting and useful property of version sort:
>
> - The empty string as a configured suffix matches all tagnames,
> including tagnames without any suffix, but
>
> - tagnames containing a "real" configured suffix are still ordered
> according to that real suffix, because any longer suffix takes
> precedence over the empty string.
>
> Exploiting this property we can easily generalize suffix reordering
> and specify the order of tags with given suffixes not only before but
> even after a main release tag by using the empty suffix to denote the
> position of the main release tag, without any algorithm changes:
>
> $ git -c versionsort.prereleaseSuffix=-alpha \
> -c versionsort.prereleaseSuffix=-beta \
> -c versionsort.prereleaseSuffix="" \
> -c versionsort.prereleaseSuffix=-gamma \
> -c versionsort.prereleaseSuffix=-delta \
> tag -l --sort=version:refname 'v3.0*'
> v3.0-alpha1
> v3.0-beta1
> v3.0
> v3.0-gamma1
> v3.0-delta1
>
> Since 'versionsort.prereleaseSuffix' is not a fitting name for a
> configuration variable to control this more general suffix reordering,
> introduce the new variable 'versionsort.suffix'. Still keep the old
> configuration variable name as a deprecated alias, though, to avoid
> suddenly breaking setups already using it. Ignore the old variable if
> both old and new configuration variables are set, but emit a warning
> so users will be aware of it and can fix their configuration. Extend
> the documentation to describe and add a test to check this more
> general behavior.
>
> Note: since the empty suffix matches all tagnames, tagnames with
> suffixes not included in the configuration are listed together with
> the suffixless main release tag, ordered lexicographically right after
> that, i.e. before tags with suffixes listed in the configuration
> following the empty suffix.
Thanks. Will comment on the individual patches later, but the end
result looks very nice.
next prev parent reply other threads:[~2016-12-08 19:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 22:42 2.10.0: multiple versionsort.prereleasesuffix buggy? Leho Kraav (Conversion Ready)
2016-09-05 23:21 ` Jeff King
2016-09-06 1:07 ` SZEDER Gábor
2016-09-06 4:07 ` Jeff King
2016-09-06 19:45 ` SZEDER Gábor
2016-09-07 15:12 ` [PATCH 0/5] Fix version sort prerelease reordering bug SZEDER Gábor
2016-09-07 15:12 ` [PATCH 1/5] t7004-tag: delete unnecessary tags with test_when_finished SZEDER Gábor
2016-09-07 15:12 ` [PATCH 2/5] t7004-tag: use test_config helper SZEDER Gábor
2016-09-07 15:12 ` [PATCH 3/5] t7004-tag: add version sort tests to show prerelease reordering issues SZEDER Gábor
2016-09-07 15:12 ` [PATCH 4/5] versioncmp: pass full tagnames to swap_prereleases() SZEDER Gábor
2016-09-08 17:49 ` Junio C Hamano
2016-09-08 20:37 ` SZEDER Gábor
2016-09-08 21:31 ` Junio C Hamano
2016-09-07 15:12 ` [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix SZEDER Gábor
2016-09-07 15:48 ` SZEDER Gábor
2016-09-09 10:43 ` Duy Nguyen
2016-10-05 1:33 ` SZEDER Gábor
2016-10-05 17:01 ` Junio C Hamano
2016-10-05 21:26 ` SZEDER Gábor
2016-10-05 22:15 ` Junio C Hamano
2016-10-06 0:40 ` Jacob Keller
2016-10-06 5:48 ` Duy Nguyen
2016-12-08 14:23 ` [PATCHv2 0/7] Fix and generalize version sort reordering SZEDER Gábor
2016-12-08 14:23 ` [PATCHv2 1/7] t7004-tag: delete unnecessary tags with test_when_finished SZEDER Gábor
2016-12-08 14:23 ` [PATCHv2 2/7] t7004-tag: use test_config helper SZEDER Gábor
2016-12-08 14:23 ` [PATCHv2 3/7] t7004-tag: add version sort tests to show prerelease reordering issues SZEDER Gábor
2016-12-08 14:23 ` [PATCHv2 4/7] versioncmp: pass full tagnames to swap_prereleases() SZEDER Gábor
2016-12-08 14:23 ` [PATCHv2 5/7] versioncmp: cope with common part overlapping with prerelease suffix SZEDER Gábor
2016-12-12 21:27 ` Junio C Hamano
2016-12-13 0:27 ` SZEDER Gábor
2016-12-13 6:39 ` Junio C Hamano
2016-12-08 14:24 ` [PATCHv2 6/7] versioncmp: use earliest-longest contained suffix to determine sorting order SZEDER Gábor
2016-12-08 14:48 ` [PATCHv2 6.5/7] squash! " SZEDER Gábor
2016-12-08 14:24 ` [PATCHv2 7/7] versioncmp: generalize version sort suffix reordering SZEDER Gábor
2016-12-08 19:36 ` Junio C Hamano [this message]
2016-12-14 17:08 ` [PATCHv2 0/7] Fix and generalize version sort reordering Jeff King
2016-12-14 17:36 ` Junio C Hamano
2016-12-20 8:50 ` SZEDER Gábor
2016-12-20 16:49 ` Jeff King
2016-09-06 7:12 ` 2.10.0: multiple versionsort.prereleasesuffix buggy? Leho Kraav (Conversion Ready)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60mutdpi.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=leho@conversionready.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).