From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
David Turner <David.Turner@twosigma.com>,
Brandon Williams <bmwill@google.com>
Subject: Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion
Date: Tue, 13 Dec 2016 11:47:08 -0800 [thread overview]
Message-ID: <xmqq60mn3937.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYsfybEBnWzv4OjCCLe70fNS=roZdKDbN_DSb4PDVJj7g@mail.gmail.com> (Stefan Beller's message of "Tue, 13 Dec 2016 11:38:57 -0800")
Stefan Beller <sbeller@google.com> writes:
> The desired standard for submodules is to have the git dir inside the
> superprojects git dir (since 501770e, Aug 2011, Move git-dir for
> submodules), which is why I think an "embedded submodule git dir"
> is inside the superproject already.
Think how you start a new submodule. What are the steps you take
before you say "git submodule add"? And where does .git for the
submodule live at that point?
With the current system, you as the submodule originator need to do
something different to make your working tree of the superproject
match what the others who clone from your public repository.
And comparing the two layout, the one originally held by the
submodule originator has .git embedded in the working tree, no?
All of the above is coming from "submodule" centric mindset. It
just is not centric to those who follow what others originated.
next prev parent reply other threads:[~2016-12-13 19:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 1:40 [PATCH 0/6] git-rm absorbs submodule git directory before deletion Stefan Beller
2016-12-13 1:40 ` [PATCH 1/6] submodule.h: add extern keyword to functions Stefan Beller
2016-12-13 1:40 ` [PATCH 2/6] submodule: modernize ok_to_remove_submodule to use argv_array Stefan Beller
2016-12-13 1:40 ` [PATCH 3/6] submodule: add flags to ok_to_remove_submodule Stefan Beller
2016-12-13 1:40 ` [PATCH 4/6] ok_to_remove_submodule: absorb the submodule git dir Stefan Beller
2016-12-13 1:40 ` [PATCH 5/6] t3600: slightly modernize style Stefan Beller
2016-12-13 1:40 ` [PATCH 6/6] rm: add absorb a submodules git dir before deletion Stefan Beller
2016-12-13 3:28 ` brian m. carlson
2016-12-13 17:51 ` Stefan Beller
2016-12-13 18:06 ` David Turner
2016-12-13 7:28 ` [PATCH 0/6] git-rm absorbs submodule git directory " Junio C Hamano
2016-12-13 17:55 ` Stefan Beller
2016-12-13 18:53 ` Junio C Hamano
2016-12-13 19:07 ` Stefan Beller
2016-12-13 19:11 ` Junio C Hamano
2016-12-13 19:13 ` Stefan Beller
2016-12-13 19:38 ` Stefan Beller
2016-12-13 19:47 ` Junio C Hamano [this message]
2016-12-13 20:09 ` Stefan Beller
2016-12-13 20:22 ` Stefan Beller
2016-12-13 19:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60mn3937.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=David.Turner@twosigma.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).