From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] validate_headref: NUL-terminate HEAD buffer
Date: Wed, 27 Sep 2017 16:28:08 +0900 [thread overview]
Message-ID: <xmqq60c44n3r.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170927071625.3dtljf5oaiaa5pjq@sigill.intra.peff.net> (Jeff King's message of "Wed, 27 Sep 2017 03:16:25 -0400")
Jeff King <peff@peff.net> writes:
> I had the same concern, but actually truncation is not a problem here
> (for a symlink or a symref). We are only seeing if the contents look
> vaguely correct, so really we never parse past "refs/" in either case.
Ahh, OK.
It seems that at least for this week, my reviews always show you
thought things more thoroughly than I did, which is good in a weird
sort of sense ;-)
next prev parent reply other threads:[~2017-09-27 7:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 6:16 [PATCH 0/3] validate_headref: avoid reading uninitialized bytes Jeff King
2017-09-27 6:17 ` [PATCH 1/3] validate_headref: NUL-terminate HEAD buffer Jeff King
2017-09-27 7:06 ` Junio C Hamano
2017-09-27 7:16 ` Jeff King
2017-09-27 7:28 ` Junio C Hamano [this message]
2017-09-27 6:17 ` [PATCH 2/3] validate_headref: use skip_prefix for symref parsing Jeff King
2017-09-27 7:07 ` Junio C Hamano
2017-09-27 6:17 ` [PATCH 3/3] validate_headref: use get_oid_hex for detached HEADs Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60c44n3r.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).