From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 4110F1FF32 for ; Thu, 12 Oct 2017 02:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752440AbdJLCdh (ORCPT ); Wed, 11 Oct 2017 22:33:37 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:57693 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752120AbdJLCdg (ORCPT ); Wed, 11 Oct 2017 22:33:36 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 5448EB673A; Wed, 11 Oct 2017 22:33:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=RldJrpvxB7MXL9FVO9zzwimOcDA=; b=o1AO+7 WUvUw5/m+yeGsTmq8Kie9w9FqwHmSxIZGY9Y7+TUQA5z9upnPMvLC7xpqYWl/DAG TNZi423YohzUwxYS1BcVsp7vGDFXMs8kRqM6W1wd9j4qK+acnoh8UPX80c0BdieL FVpqzRUHl+foml14ozyUzcixG5gdKIjkhXpwo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=ssw5MQhsuF/XyAijJ/bAiw6JRT+LSwfU AwYrvx48e6x+TeBOb9q9qFOAtbs+uwIuABD9Fe4fPT6hko+5CX6LL8Fg8P8/QJ6J mFe6fE4uV0StOQA/V1/9p1hpnFWp9S5hwGgFQNc7WJu5hE0//i49W6F0eaL4HOxp NN2U/gbwcqY= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4B8D6B6739; Wed, 11 Oct 2017 22:33:36 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id AFD85B6737; Wed, 11 Oct 2017 22:33:35 -0400 (EDT) From: Junio C Hamano To: Jameson Miller Cc: bmwill@google.com, git@vger.kernel.org, jamill@microsoft.com, peff@peff.net, sbeller@google.com Subject: Re: [PATCH v2 0/5] Teach Status options around showing ignored files References: <20171005205443.206900-1-jameson.miller81@gmail.com> <20171011133504.15049-1-jamill@microsoft.com> Date: Thu, 12 Oct 2017 11:33:34 +0900 In-Reply-To: <20171011133504.15049-1-jamill@microsoft.com> (Jameson Miller's message of "Wed, 11 Oct 2017 09:34:59 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: BF4FD880-AEF5-11E7-9DCE-8EF31968708C-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jameson Miller writes: > Changes in v2: > > Addressed review comments from the original series: > > * Made fixes / simplifications suggested for documentation > > * Removed test_tick from test scripts > > * Merged 2 commits (as suggested) > > Jameson Miller (5): > Teach status options around showing ignored files > Update documentation for new directory and status logic > Add tests for git status `--ignored=matching` > Expand support for ignored arguments on status > Add tests around status handling of ignored arguments Please make sure these titles mix well when they appear together with changes from other people that are completely unrelated to them. Keep in mind that your "git status" is *not* the most important thing in the world (of course, it is no less important than others, either). Perhaps status: add new options to show ignored files differently status: document logic to show new directory status: test --ignored=matching etc. Rules of thumb: (1) choose ": " prefix appropriately (2) keep them short and to the point (3) word that follow ": " prefix is not capitalized (4) no need for full-stop at the end of the title