From: Junio C Hamano <gitster@pobox.com>
To: "W. Trevor King" <wking@tremily.us>
Cc: Git <git@vger.kernel.org>, "Łukasz Gryglicki" <lukaszgryglicki@o2.pl>
Subject: Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"
Date: Thu, 12 Oct 2017 14:42:30 +0900 [thread overview]
Message-ID: <xmqq60bk2a7t.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171012053002.GZ11004@valgrind.tremily.us> (W. Trevor King's message of "Wed, 11 Oct 2017 22:30:02 -0700")
"W. Trevor King" <wking@tremily.us> writes:
> On Thu, Oct 12, 2017 at 10:17:51AM +0900, Junio C Hamano wrote:
>> "W. Trevor King" <wking@tremily.us> writes:
>>
>> > Following 09c2cb87 (pull: pass --allow-unrelated-histories to "git
>> > merge", 2016-03-18) with the tests also drawing on 14d01b4f (merge:
>> > add a --signoff flag, 2017-07-04).
>>
>> I cannot find a verb in the above.
>
> I'd meant it as either a continuation of the subject line, or with an
Never do that. The title should be able to stand on its own, and
must not be an early part of incomplete sentence.
> Much nicer, thanks. I'll add a patch to v2 to make the same change to
> t7614.
> ...
> Sounds good. I'll add a patch to v2 to make the same change to the
> existing t5521 --allow-unrelated-histories test.
Please don't, unless you are actively working on the features that
they test. We do not have infinite amount of bandwidth to deal with
changes for the sake of perceived consistency and no other real
gain.
next prev parent reply other threads:[~2017-10-12 5:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 20:10 [PATCH] pull: pass --signoff/--no-signoff to "git merge" W. Trevor King
2017-10-12 1:17 ` Junio C Hamano
2017-10-12 5:30 ` W. Trevor King
2017-10-12 5:42 ` Junio C Hamano [this message]
2017-10-12 6:23 ` W. Trevor King
2017-10-12 11:08 ` Junio C Hamano
2017-10-12 8:46 ` [PATCH v2] " W. Trevor King
2017-10-12 9:18 ` W. Trevor King
2017-10-12 10:11 ` Junio C Hamano
2017-10-12 18:35 ` [PATCH v3] " W. Trevor King
2017-10-13 1:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60bk2a7t.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lukaszgryglicki@o2.pl \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).