From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Re: reduce_heads: fix memory leaks
Date: Mon, 06 Nov 2017 10:12:40 +0900 [thread overview]
Message-ID: <xmqq60aoky5z.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <cover.1509908607.git.martin.agren@gmail.com> ("Martin Ågren"'s message of "Sun, 5 Nov 2017 21:26:29 +0100")
Martin Ågren <martin.agren@gmail.com> writes:
> Since v1 [1], I've added a preparatory patch to UNLEAK some variables.
> That sets the stage slightly better for patch 2.
>
> Junio, you placed v1 on maint. Because UNLEAK is not in maint, this is
> based on master and maint misses out on this v2. If you have any advice
> for how I should (not) do series with UNLEAK in them, I'm all ears.
As far as we know, nobody reported that these leaks made Git run out
of memory while running merge-base and prevented them from getting
desired result, so it is not worth the effort to make (part of) them
mergeable to 'maint'. I forked the branch from 'maint' only because
it was a fix and it was not harder than forking from 'master'.
If 2/2 (which was 1/1 in the v1) were fixes to a very grave error,
then I might have suggested to do the 2/2 on maint first and call
that topic ${some_grave_error}_fix-maint; then fork another topic
${some_grave_error}_fix at master, merge the _fix-maint topic in,
and then do the 1/2 on top.
prev parent reply other threads:[~2017-11-06 1:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 9:03 [PATCH] reduce_heads: fix memory leaks Martin Ågren
2017-11-02 3:11 ` Junio C Hamano
2017-11-02 10:45 ` Martin Ågren
2017-11-05 20:26 ` [PATCH v2 0/2] " Martin Ågren
2017-11-05 20:26 ` [PATCH v2 1/2] builtin/merge-base: UNLEAK commit lists Martin Ågren
2017-11-06 1:03 ` Junio C Hamano
2017-11-06 11:05 ` Jeff King
2017-11-07 20:39 ` [PATCH v3 1/2] builtin/merge-base: free " Martin Ågren
2017-11-08 2:40 ` Junio C Hamano
2017-11-07 20:39 ` [PATCH v3 2/2] reduce_heads: fix memory leaks Martin Ågren
2017-11-05 20:26 ` [PATCH v2 " Martin Ågren
2017-11-06 1:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60aoky5z.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).