git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Kyle Meyer <kyle@kyleam.com>,
	git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH v3] range-diff: update stale summary of --no-dual-color
Date: Mon, 27 Aug 2018 10:57:37 -0700	[thread overview]
Message-ID: <xmqq5zzvlmjy.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180823221152.GD99542@aiede.svl.corp.google.com> (Jonathan Nieder's message of "Thu, 23 Aug 2018 15:11:52 -0700")

Jonathan Nieder <jrnieder@gmail.com> writes:

> Junio C Hamano wrote:
>> Jonathan Nieder <jrnieder@gmail.com> writes:
>>> Kyle Meyer wrote:
>
>>>> Subject: [PATCH v3] range-diff: update stale summary of --no-dual-color
> [...]
>>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>>
>> Sorry, too late.  I'll revert the merge of the previous round out of
>> 'next' and requeue this one, but that will have to wait until the
>> next integration cycle.
>
> Thanks for the heads up.  Sounds like a fine plan.

Having said that, I do not think the change from v2 to v3 is an
improvement.  At least the one in v2 explained what the input is to
the logic to determine colors, helping the users to understand what
is painted and why and decide if that coloring is useful to them.

The phrasing in v3, "use simple diff colors", does not give much
information over saying something like "paint it differently" (which
is silly because "differently" is a given, once you give an option
to cause a non-default behaviour).

Not limited to this particular case, but in general, subjective
words like "simple" have much less information density than more
specific words, and we need to be careful when spending bits on a
limited space (like option description) to them.


  reply	other threads:[~2018-08-27 17:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23  2:39 [PATCH] range-diff: update stale summary of --no-dual-color Kyle Meyer
2018-08-23  2:47 ` Jonathan Nieder
2018-08-23  3:03   ` Kyle Meyer
2018-08-23  3:22     ` Jonathan Nieder
2018-08-23  4:04       ` Kyle Meyer
2018-08-23  8:27         ` Jonathan Nieder
2018-08-23 12:00           ` [PATCH v2] " Kyle Meyer
2018-08-23 21:10             ` Jonathan Nieder
2018-08-23 21:57               ` [PATCH v3] " Kyle Meyer
2018-08-23 22:02                 ` Jonathan Nieder
2018-08-23 22:08                   ` Junio C Hamano
2018-08-23 22:11                     ` Jonathan Nieder
2018-08-27 17:57                       ` Junio C Hamano [this message]
2018-08-23 14:31       ` [PATCH] " Johannes Schindelin
2018-08-23 21:12         ` Jonathan Nieder
2018-08-23 20:54 ` Johannes Schindelin
2018-08-23 21:18   ` Junio C Hamano
2018-08-23 21:27     ` Kyle Meyer
2018-08-23 21:48       ` Junio C Hamano
2018-08-23 21:41     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zzvlmjy.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).