Re: [PATCH v7 5/7] revision: mark non-user-given objects instead

[Junio C Hamano <gitster@pobox.com>]

Matthew DeVore <matvore@google.com> writes:

> diff --git a/revision.h b/revision.h
> index 5118aaaa9..2d381e636 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -8,7 +8,11 @@
>  #include "diff.h"
>  #include "commit-slab-decl.h"
>  
> -/* Remember to update object flag allocation in object.h */
> +/* Remember to update object flag allocation in object.h
> + * NEEDSWORK: NOT_USER_GIVEN doesn't apply to commits because we only support
> + * filtering trees and blobs, but it may be useful to support filtering commits
> + * in the future.
> + */

Just a minor style nit, but our multi-line comment begins with the
opening "/*" (and closing "*/", too, but you got that right) on its
own line, i.e.

	/*
	 * Remember to update ...

> -#define USER_GIVEN	(1u<<25) /* given directly by the user */
> +#define NOT_USER_GIVEN	(1u<<25) /* tree or blob not given directly by user */

Is "given directly by user" equivalent to "given on the command
line"?  Do objects given via "--stdin" count the same way?  How abot
those given via "--branches" or "A^@"?  Does "not given directly by
user" mean roughly the same thing as "discovered by traversal"?

Not a suggestion to change anything in this patch, but if you can
come up with a better phrase that helps new readers' understanding
so that they do not have to ask a question like this, that would be
great.

Thanks.