git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] Update .mailmap
Date: Fri, 09 Nov 2018 11:48:00 +0900	[thread overview]
Message-ID: <xmqq5zx76k67.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <b590a9bebf8ac10b6f1d85287bb8d7a8ac7082a6.1541696887.git.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Thu, 08 Nov 2018 09:08:09 -0800 (PST)")

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> This patch makes the output of `git shortlog -nse v2.10.0`
> duplicate-free.

Did you mean "v2.10.0..master" or did you really mean this covers
authors recorded up to v2.10.0?  Judging from the cover letter, I
think you meant the former.

Can you say a bit more about how one among multiple addresses for
each person was chosen in the log message?  E.g. "After asking each
author which one is the preferred one", "Picked the one with the
most recent committer timestamps", "There were two for each but one
of them were bouncing", etc.

> @@ -150,6 +155,7 @@ Mark Levedahl <mdl123@verizon.net> <mlevedahl@gmail.com>
>  Mark Rada <marada@uwaterloo.ca>
>  Martin Langhoff <martin@laptop.org> <martin@catalyst.net.nz>
>  Martin von Zweigbergk <martinvonz@gmail.com> <martin.von.zweigbergk@gmail.com>
> +Masaya Suzuki <masayasuzuki@google.com><draftcode@gmail.com>

It is a bit surprising that we can take an entry without SP in
between two addresses and still behave sensibley, but it probably
makes more sense to add one just to look similar to other entries.

Thanks for working on this.

  reply	other threads:[~2018-11-09  2:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 17:08 [PATCH 0/1] Update .mailmap Johannes Schindelin via GitGitGadget
2018-11-08 17:08 ` [PATCH 1/1] " Johannes Schindelin via GitGitGadget
2018-11-09  2:48   ` Junio C Hamano [this message]
2018-11-09 11:29     ` Johannes Schindelin
2018-11-09 11:31 ` [PATCH v2 0/1] " Johannes Schindelin via GitGitGadget
2018-11-09 11:31   ` [PATCH v2 1/1] " Johannes Schindelin via GitGitGadget
2018-11-12  3:54     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zx76k67.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).