mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: "Johannes Schindelin via GitGitGadget" <>
Subject: Re: [PATCH 0/2] stash: handle pathspec magic again
Date: Fri, 08 Mar 2019 10:37:08 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Johannes Schindelin via GitGitGadget's message of "Thu, 07 Mar 2019 07:29:32 -0800 (PST)")

"Johannes Schindelin via GitGitGadget" <>

> It was reported in that 
> git stash -- ':(glob)**/*.testextension is broken. The problem is not even
> the stash operation itself, it happens when the git add part of dropping the
> local changes is spawned: we simply passed the parsed pathspec instead of
> the unparsed one.
> While verifying the fix, I also realized that the escape hatch was seriously
> broken by my "backport of the -q option": It introduced four bogus eval 
> statements, which really need to be dropped.


We seem to be piling many "oops" on top, even after the topic hits
'next'.  But fixes are better late than never ;-).

Will queue.

  parent reply	other threads:[~2019-03-08  1:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 15:29 [PATCH 0/2] stash: handle pathspec magic again Johannes Schindelin via GitGitGadget
2019-03-07 15:29 ` [PATCH 1/2] legacy stash: fix "rudimentary backport of -q" Johannes Schindelin via GitGitGadget
2019-03-11  7:27   ` Junio C Hamano
2019-03-07 15:29 ` [PATCH 2/2] built-in stash: handle :(glob) pathspecs again Johannes Schindelin via GitGitGadget
2019-03-11  7:28   ` Junio C Hamano
2019-03-11 16:27     ` Johannes Schindelin
2019-03-11 22:19       ` Thomas Gummerer
2019-03-08  1:37 ` Junio C Hamano [this message]
2019-03-08 16:12   ` [PATCH 0/2] stash: handle pathspec magic again Johannes Schindelin
2019-03-10  0:56     ` Junio C Hamano
2019-03-11 16:25       ` Johannes Schindelin
2019-03-18  4:39         ` Junio C Hamano
2019-03-18  7:02           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).