From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH] grep: skip UTF8 checks explicitly
Date: Wed, 24 Jul 2019 09:08:59 -0700 [thread overview]
Message-ID: <xmqq5znrs9d0.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1907241248000.21907@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 24 Jul 2019 12:50:17 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> My reading of the situation is slightly different. I think
> PCRE_NO_UTF8_CHECK is off by default, but it only makes a difference in
> the non-JIT'ed code path. Since we use PCRE2's JIT when possible
> (because it leads to a quite nice performance improvement), we usually
> don't see those warnings. Carlo's patch makes the non-JIT'ed code path
> behave the same as our preferred code path.
You're right and we do want to make both codepaths behave the same
way. The case we are having trouble with is without JIT, where the
machinery to look for needle in a non-UTF8 binary haystack barfs and
dies, which is unacceptable (imagine "git log --grep=..."), and we
want the machinery to ignore random binary gunk just like the JIT
codepath does.
Thanks.
next prev parent reply other threads:[~2019-07-24 16:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 18:31 [PATCH] grep: skip UTF8 checks explicitally Carlo Marcelo Arenas Belón
2019-07-21 18:34 ` Eric Sunshine
2019-07-22 11:55 ` Johannes Schindelin
2019-07-22 14:43 ` [PATCH] grep: skip UTF8 checks explicitly Carlo Marcelo Arenas Belón
2019-07-24 2:10 ` Junio C Hamano
2019-07-24 10:50 ` Johannes Schindelin
2019-07-24 16:08 ` Junio C Hamano [this message]
2019-08-28 14:54 ` [PATCH v2] " Carlo Marcelo Arenas Belón
2019-08-28 16:57 ` Carlo Arenas
2019-09-09 15:07 ` Carlo Arenas
2019-09-09 18:49 ` Junio C Hamano
2019-07-22 19:42 ` [PATCH] grep: skip UTF8 checks explicitally Ævar Arnfjörð Bjarmason
2019-07-23 3:50 ` Carlo Arenas
2019-07-23 12:46 ` Johannes Schindelin
2019-07-24 1:47 ` Carlo Arenas
2019-07-24 10:47 ` Johannes Schindelin
2019-07-24 18:22 ` Ævar Arnfjörð Bjarmason
2019-07-24 21:04 ` Junio C Hamano
2019-07-25 9:48 ` Johannes Schindelin
2019-07-25 13:02 ` Junio C Hamano
2019-07-25 18:22 ` Johannes Schindelin
2019-07-26 15:15 ` Ævar Arnfjörð Bjarmason
2019-07-26 15:53 ` Carlo Arenas
2019-07-26 20:05 ` Ævar Arnfjörð Bjarmason
2019-07-26 16:19 ` Junio C Hamano
2019-07-26 19:40 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5znrs9d0.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).