git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] git-gui: Call do_quit before destroying the main window
Date: Wed, 07 Aug 2019 10:50:10 -0700	[thread overview]
Message-ID: <xmqq5zn8j25p.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <549ad583-5ca1-7096-f4ce-10e8a836f7f9@yadavpratyush.com> (Pratyush Yadav's message of "Wed, 7 Aug 2019 00:34:51 +0530")

Pratyush Yadav <me@yadavpratyush.com> writes:

> So if I fork the project, will you pull from my fork? If yes, what
> exactly would I have to do? Make a set of changes and then ask on the
> list for you to pull from my fork?
>
> I am a relatively inexperienced programmer, and it feels like a kinda
> big responsibility that I'm not sure I am ready for. But maybe you can
> look at the changes from a high level POV before pulling, so there is
> someone sanity checking my changes.

This patch as a one-off thing may not be too bad, as it already had
exposure to the list (and there probably are more people scanning it
than it would have been if you silently made a pull request on
GitHub, because they saw messages from me in this thread).

BUT.

If I make it a habit to pull git-gui stuff from random people who
are not committed to and/or feel experienced enough for working on
git-gui, the result would be even worse than taking patches on
git-gui directly from the list.  At least a patch on the list I can
see how others react (or not react).  On the other hand, I do not
know how to interpret lack of comments from others on GitHub pull
request---perhaps nobody thought it was a good change, perhaps
nobody is paying attention to it, or what other possibilities there
are.

So,... quite honestly, I'd rather not.

  parent reply	other threads:[~2019-08-07 17:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 14:39 Pratyush Yadav
2019-08-06 15:52 ` Pratyush Yadav
2019-08-06 18:22   ` Junio C Hamano
2019-08-06 19:04     ` Pratyush Yadav
2019-08-07  5:21       ` Junio C Hamano
2019-08-07 17:41         ` Junio C Hamano
2019-08-07 17:50       ` Junio C Hamano [this message]
2019-08-07 21:03         ` Pratyush Yadav
2019-08-07 21:53           ` Junio C Hamano
2019-08-09 14:42             ` Pratyush Yadav
2019-08-09 20:03               ` Junio C Hamano
2019-08-13 13:40                 ` Pratyush Yadav
2019-08-13 17:30                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zn8j25p.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    --subject='Re: [PATCH] git-gui: Call do_quit before destroying the main window' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).