From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Thomas Rast <tr@thomasrast.ch>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH 2/2] Documentation/git-log: mention that line-log regex must match in starting revision
Date: Tue, 17 Dec 2019 10:16:24 -0800 [thread overview]
Message-ID: <xmqq5zieizrb.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <1d033204-80fd-25f8-3a80-0cb641953139@gmail.com> (Derrick Stolee's message of "Tue, 17 Dec 2019 10:34:43 -0500")
Derrick Stolee <stolee@gmail.com> writes:
> On 12/17/2019 12:07 AM, Philippe Blain via GitGitGadget wrote:
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>> When giving a regex as parameter <start> or <end> in
>> `git log -L <start>,<end>:<file>`, or a function name in
>> `git log -L :<funcname>:<file>`, the given regex must match in the starting
>> revision, or else the command exits with a fatal error.
>>
>> This is not obvious in the documentation, so add a note to that
>> effect.
>
> This seems helpful. Thanks.
Even when you specify <start> or <end> as a line number, they must
exist in the starting revision or it would be a fatal error. If we
are clarifying with this patch for completeness, I think we should
also mention it together.
Or we could even drop the mention of regex and say <start> and
<end>, regardless of how they are specified (including :<funcname>
format), must exist in the starting revision.
next prev parent reply other threads:[~2019-12-17 18:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 5:07 [PATCH 0/2] Improve line log documentation Philippe Blain via GitGitGadget
2019-12-17 5:07 ` [PATCH 1/2] Documentation/git-log: document accepted line-log diff formats Philippe Blain via GitGitGadget
2019-12-17 11:33 ` SZEDER Gábor
2019-12-18 2:44 ` Philippe Blain
2019-12-17 15:33 ` Derrick Stolee
2019-12-18 2:47 ` Philippe Blain
2019-12-17 5:07 ` [PATCH 2/2] Documentation/git-log: mention that line-log regex must match in starting revision Philippe Blain via GitGitGadget
2019-12-17 15:34 ` Derrick Stolee
2019-12-17 18:16 ` Junio C Hamano [this message]
2019-12-18 3:28 ` Philippe Blain
2019-12-18 10:55 ` Derrick Stolee
2019-12-18 11:49 ` SZEDER Gábor
2019-12-18 17:59 ` Junio C Hamano
2019-12-26 17:46 ` Philippe Blain
2019-12-18 11:09 ` SZEDER Gábor
2019-12-26 17:43 ` [PATCH v2 0/2] Improve line log documentation Philippe Blain via GitGitGadget
2019-12-26 17:43 ` [PATCH v2 1/2] doc: log, gitk: document accepted line-log diff formats Philippe Blain via GitGitGadget
2019-12-26 17:43 ` [PATCH v2 2/2] doc: log, gitk: line-log arguments must exist in starting revision Philippe Blain via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zieizrb.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=stolee@gmail.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).