From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org, Danh Doan <congdanhqx@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v12 5/5] bugreport: add compiler info
Date: Mon, 06 Apr 2020 16:31:10 -0700 [thread overview]
Message-ID: <xmqq5zecur7l.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200406224526.256074-6-emilyshaffer@google.com> (Emily Shaffer's message of "Mon, 6 Apr 2020 15:45:26 -0700")
Emily Shaffer <emilyshaffer@google.com> writes:
> To help pinpoint the source of a regression, it is useful to know some
> info about the compiler which the user's Git client was built with. By
> adding a generic get_compiler_info() in 'compat/' we can choose which
> relevant information to share per compiler; to get started, let's
> demonstrate the version of glibc if the user built with 'gcc'.
This one is not about "what system are we running on", but more
about "how were the various pieces of Git binaries the user has
trouble running built?". While it may be useful to learn how "git
bugreport" was compiled, the same question about the other binaries
of Git (e.g. "git" itself, or "git ls-files" that is builtin) may
have different answers. It should be fairly trivial to teach the
"git" binaries (i.e. "git" itself plus builtins, and standalone
subcommands like "git-remote-curl" and "git-bugreport") to report
how they were built (e.g. with what library and compiler) by calling
the helpers you added in [3/5] and [5/5] and once that is done, it
would be straight-forward to teach "git bugreport" to collect
properties of them by invoking them and reading their output via the
run_command() interface, as I mentioned in my review on [3/5]
earlire.
Thanks.
next prev parent reply other threads:[~2020-04-06 23:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 21:43 [PATCH v10 0/5] add git-bugreport tool Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 1/5] help: move list_config_help to builtin/help Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 2/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 3/5] bugreport: gather git version and build info Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 4/5] bugreport: add uname info Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 5/5] bugreport: add compiler info Emily Shaffer
2020-03-23 23:10 ` Junio C Hamano
2020-03-25 21:10 ` Emily Shaffer
2020-03-25 21:24 ` [PATCH v11 0/5] add git-bugreport tool Emily Shaffer
2020-03-25 21:24 ` [PATCH v11 1/5] help: move list_config_help to builtin/help Emily Shaffer
2020-03-25 21:24 ` [PATCH v11 2/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-04-01 20:17 ` SZEDER Gábor
2020-03-25 21:24 ` [PATCH v11 3/5] bugreport: gather git version and build info Emily Shaffer
2020-03-25 21:24 ` [PATCH v11 4/5] bugreport: add uname info Emily Shaffer
2020-03-25 21:25 ` [PATCH v11 5/5] bugreport: add compiler info Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 0/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 1/5] help: move list_config_help to builtin/help Emily Shaffer
2020-04-06 23:04 ` Junio C Hamano
2020-04-06 22:45 ` [PATCH v12 2/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 3/5] bugreport: gather git version and build info Emily Shaffer
2020-04-06 23:17 ` Junio C Hamano
2020-04-07 18:42 ` Emily Shaffer
2020-04-07 20:05 ` Junio C Hamano
2020-04-07 20:34 ` Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 4/5] bugreport: add uname info Emily Shaffer
2020-04-06 23:20 ` Junio C Hamano
2020-04-06 22:45 ` [PATCH v12 5/5] bugreport: add compiler info Emily Shaffer
2020-04-06 23:31 ` Junio C Hamano [this message]
2020-04-06 23:47 ` Danh Doan
2020-04-07 15:09 ` Junio C Hamano
2020-04-07 18:35 ` Emily Shaffer
2020-04-07 15:24 ` [PATCH v12 0/5] bugreport: add tool to generate debugging info Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zecur7l.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=congdanhqx@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).