From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7364E1F5AE for ; Tue, 7 Jul 2020 18:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728149AbgGGSOl (ORCPT ); Tue, 7 Jul 2020 14:14:41 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:63844 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728029AbgGGSOl (ORCPT ); Tue, 7 Jul 2020 14:14:41 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id F11A16EDB5; Tue, 7 Jul 2020 14:14:38 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=6gUmlFpFXnNxumpojwQHGEPh5e4=; b=wgmzpA N4LP4HfDD08g9xJNOLpeAmt9R/yPTidEWRkZZArtRr9AWrmtqS70NSiOSuV6aNmn MEBISPxm9vjPb2RYRL3AAvOM+njQisF183CnR30mCiPXrGQoP8fqWvMDHkkU88sL vpMg+g1Dwk6PSx/tcRFcsYW3mNXBRp2CFmGT0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=wt6ywt2j3kqiXyaMHJIV/vyfmtJvY8GB JafIWTSvTq1B9yL/jGOwg4EULpx/DTi+ESviO7L8D5XXSYrPHEAjV7yKip6ZnFSd VwwqQsP4svc/0MyIt//mFWLz3ROIEiDheN+QDkMN2ZC2+2nBeEO0uLGaOpJXzEyw 7AQg2Bt5fjM= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id E8FFC6EDB4; Tue, 7 Jul 2020 14:14:38 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 703176EDB0; Tue, 7 Jul 2020 14:14:38 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Han-Wen Nienhuys Cc: Han-Wen Nienhuys via GitGitGadget , git , Han-Wen Nienhuys Subject: Re: [PATCH 1/2] Modify pseudo refs through ref backend storage References: <6821f57bdf326f161f152a8af0e47b54513c77b1.1594056572.git.gitgitgadget@gmail.com> Date: Tue, 07 Jul 2020 11:14:37 -0700 In-Reply-To: (Han-Wen Nienhuys's message of "Tue, 7 Jul 2020 19:15:32 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B85CAF0C-C07D-11EA-A84C-C28CBED8090B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Han-Wen Nienhuys writes: > I can fix this specific instance here (which is what I think you > want), for this commit to practice what it preaches. At the same time > there are probably about 100 or so other places where the tests check > the file system directly for ref(log) existence, so it would never be > totally consistent. > > The only way to systematically find the offending places is to > introduce a new ref backend and then fix all the tests, and I think > that goes outside the scope of this small series. Good. I think we are on the same page. I suggested to make the patch internally consistent, nothing more. And fixing everything in the world is outside the scope of these two patches. Thanks.