From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Edmundo Carmona Antoranz" <eantoranz@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>,
"René Scharfe" <l.s.r@web.de>,
whydoubt@gmail.com, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] blame.c: replace instance of !oidcmp for oideq
Date: Wed, 09 Sep 2020 13:06:09 -0700 [thread overview]
Message-ID: <xmqq5z8mvhou.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200909191746.GA2514794@coredump.intra.peff.net> (Jeff King's message of "Wed, 9 Sep 2020 15:17:46 -0400")
Jeff King <peff@peff.net> writes:
> @@
> -struct object_id *OIDPTR1;
> -struct object_id *OIDPTR2;
> +expression OIDPTR1;
> +expression OIDPTR2;
> @@
> - oidcmp(OIDPTR1, OIDPTR2) == 0
> + oideq(OIDPTR1, OIDPTR2)
> @@ -71,8 +71,8 @@ expression E1, E2;
> ...>}
>
> @@
> -struct object_id *OIDPTR1;
> -struct object_id *OIDPTR2;
> +expression *OIDPTR1;
> +expression *OIDPTR2;
> @@
> - oidcmp(OIDPTR1, OIDPTR2) != 0
> + !oideq(OIDPTR1, OIDPTR2)
With an extra insight from the counter-example Réne pointed out in
your message, I think the above two are safe but all the others are
unsafe.
next prev parent reply other threads:[~2020-09-09 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 17:16 [PATCH] blame.c: replace instance of !oidcmp for oideq Edmundo Carmona Antoranz
2020-09-07 17:21 ` Edmundo Carmona Antoranz
2020-09-08 13:55 ` Edmundo Carmona Antoranz
2020-09-08 19:07 ` Derrick Stolee
2020-09-09 9:11 ` Jeff King
2020-09-09 14:00 ` Edmundo Carmona Antoranz
2020-09-09 17:48 ` Jeff Smith
2020-09-09 19:13 ` Jeff King
2020-09-09 19:17 ` Jeff King
2020-09-09 19:54 ` René Scharfe
2020-09-09 19:58 ` Jeff King
2020-09-09 20:03 ` Junio C Hamano
2020-09-09 20:06 ` Junio C Hamano [this message]
2020-09-09 20:43 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5z8mvhou.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).