From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 277591F66F for ; Thu, 29 Oct 2020 20:25:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbgJ2UZo (ORCPT ); Thu, 29 Oct 2020 16:25:44 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:51558 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725764AbgJ2UZo (ORCPT ); Thu, 29 Oct 2020 16:25:44 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 7F9CE102FF0; Thu, 29 Oct 2020 16:25:42 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=gTNSobmioiWyV88SXwPYaeRG2O4=; b=Wy81VD 9lwU7vjXVUF4RRph4PqGV8ZEXKN2/n6+GX12lXYR5ZqpIGK7/N3TfUfzJP4HHsLH cfq2xw2TyZbH3rYlhOdsRjUoJPf8I1o/qqV8uZT09UxO8+hYQeUHAqEtaVwoDfek zPjwZIr13KPiC/psOo2ryN6DIHS5LAtR49YJ0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=oLhoTzRXT2cJIFh5HMGFOUGfRCPbvEnc mmx/kELLoSLxopN7uZuUTVCI4g0CPPCugTEQiZo+UOmrtw6VLyNSMyMkkCBeT3T9 DVKYYXFdq3Gvz5HrCvXtSh+mf5h8pI7Rc+3socGlqGCiw2D3iP+vmPKOtCNwurFT raTfXpTmIqo= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 786FC102FEF; Thu, 29 Oct 2020 16:25:42 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id AC8D4102FEC; Thu, 29 Oct 2020 16:25:38 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Philippe Blain via GitGitGadget" Cc: git@vger.kernel.org, Thomas Rast , Eric Sunshine , =?utf-8?Q?Ren=C3=A9?= Scharfe , Philippe Blain Subject: Re: [PATCH 3/6] blame-options.txt: also mention 'funcname' in '-L' description References: Date: Thu, 29 Oct 2020 13:25:37 -0700 In-Reply-To: (Philippe Blain via GitGitGadget's message of "Wed, 28 Oct 2020 12:47:47 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: E8862D24-1A24-11EB-A038-D609E328BF65-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Philippe Blain via GitGitGadget" writes: > From: Philippe Blain > > Make it clearer that a function can be blamed by feeding `git blame` > '-L :' by mentioning it at the beginnning of the description > of the '-L' option. I think it makes tons of sense to mention both , range and range in the description. It is not a new issue you are introducing with this change, but I think the latter does not deserve to be treated as if it were an afterthought by being a mere parenthetical mention. > -L ,:: > -L ::: > - Annotate only the given line range. May be specified multiple times. > - Overlapping ranges are allowed. > + Annotate only the line range given by ',' > + (or by the function name regex ''). > + May be specified multiple times. Overlapping ranges are allowed. > + > '' and '' are optional. `-L ` or `-L ,` spans from > '' to end of file. `-L ,` spans from start of file to ''.