From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7586D1F4B4 for ; Wed, 23 Dec 2020 13:57:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728704AbgLWNzH (ORCPT ); Wed, 23 Dec 2020 08:55:07 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:55964 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728701AbgLWNzH (ORCPT ); Wed, 23 Dec 2020 08:55:07 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CBCD4A7DBA; Wed, 23 Dec 2020 08:54:24 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type :content-transfer-encoding; s=sasl; bh=KdXHUQsJJd1BAyoW7IQLTvPsP bM=; b=UhOTsaD9UQsfyXdr/+mG1ujaxvrdsOIbD7SEiB4WBynCEYXy+3w/vsqJJ q0jrh3E/66fxiu+ET/n5z0ubgpzSBxOTkVfRbtu3VyxJBLaig6ekkIqfz6D35wvP 4duKgqLIFGJYPaAV4z24SCdwQ0NgZ/1NzXjcaO3MzjYiYPRBMY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=sasl; b=e1bLDK2NWhZQQRDtp8i Bzt2XQxeTOQRQ7q3WmxG9xvBkyGDDesWQXF0DrXGi8pIfO0JxzBl6QrDWogKjoRh Pty5O9pJrnH0263IfxRsoUPFqRWo2CowSa5C0Oh80VrHJ/AhfL9OAHNsaxjcX+YN hvG4AkRqPE9cMxtJYXgCOU5k= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C3130A7DB9; Wed, 23 Dec 2020 08:54:24 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 50229A7DB7; Wed, 23 Dec 2020 08:54:24 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Jeff King , "brian m . carlson" , Eric Sunshine , Johannes Schindelin Subject: Re: [PATCH v4 00/20] make "mktag" use fsck_tag() & more References: <20201209200140.29425-1-avarab@gmail.com> <20201223013606.7972-1-avarab@gmail.com> Date: Wed, 23 Dec 2020 05:54:23 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 5D6D2D14-4526-11EB-B8B2-D152C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > So, when re-rolling this with Junio's small fixup this grew in scope a > bit, but should paradoxically be easier to deal with even though it's > 2x the size now. Read on: The core part didn't change all that much, which made it a bit easier to see. I left comments here and there, but the series mostly looked sensible in general. Thanks.