From: Junio C Hamano <gitster@pobox.com>
To: Dan Moseley <Dan.Moseley@microsoft.com>
Cc: "tboegi@web.de" <tboegi@web.de>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [EXTERNAL] [PATCH v2 1/1] git mv foo FOO ; git mv foo bar gave an assert
Date: Mon, 01 Mar 2021 13:47:45 -0800 [thread overview]
Message-ID: <xmqq5z2ao8am.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <BYAPR21MB1158CDD04067369BB367474CE09A9@BYAPR21MB1158.namprd21.prod.outlook.com> (Dan Moseley's message of "Mon, 1 Mar 2021 20:23:13 +0000")
Dan Moseley <Dan.Moseley@microsoft.com> writes:
> Thank you Thorsten. This makes sense to me. Do you want to add a test?
> I believe this is what I had in my original patch, that worked pretty well:
Would this succeed unconditionally on all platforms, or only
relevant on case-insensitive filesystems? Lack of any prerequisite
on a new test is a good thing (if it is correct), but the
description of the change talked about case insensitivity, so ...
> diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
> index 63d5f41a12..5c7fee9bd8 100755
> --- a/t/t7001-mv.sh
> +++ b/t/t7001-mv.sh
> @@ -152,6 +152,14 @@ test_expect_success \
> 'move into "."' \
> 'git mv path1/path2/ .'
>
> +test_expect_success \
> + 'fail to move file already in index under different cased name' \
> + 'echo 1 > foo &&
> + git add foo &&
> + git commit -m add_file -- foo &&
> + git mv foo FOO &&
> + test_expect_code 128 git mv foo BAR'
> +
> test_expect_success "Michael Cassar's test case" '
> rm -fr .git papers partA &&
> git init &&
next prev parent reply other threads:[~2021-03-01 21:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BYAPR21MB1158F64E1141453F7D00B46CE0D89@BYAPR21MB1158.namprd21.prod.outlook.com>
[not found] ` <BYAPR21MB11585FFD46DEE7AD4EEEFEABE0D89@BYAPR21MB1158.namprd21.prod.outlook.com>
2020-12-29 2:06 ` [PATCH] git-mv: fix git mv bug with case insensitive fs Dan Moseley
2020-12-31 7:13 ` Torsten Bögershausen
2021-01-06 4:05 ` Junio C Hamano
2021-01-06 10:53 ` [PATCH/RFC v1 1/1] git mv foo FOO ; git mv foo bar gave an assert tboegi
2021-01-06 23:51 ` Junio C Hamano
2021-03-01 17:05 ` [PATCH v2 " tboegi
2021-03-01 19:21 ` Junio C Hamano
2021-03-01 19:36 ` Chris Torek
2021-03-01 21:53 ` Junio C Hamano
[not found] ` <20210301170425.12154-1-tboegi@web.de>
2021-03-01 20:23 ` [EXTERNAL] " Dan Moseley
2021-03-01 21:47 ` Junio C Hamano [this message]
2021-03-01 21:41 ` [PATCH v3 " tboegi
2021-03-01 23:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5z2ao8am.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Dan.Moseley@microsoft.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).