From: Junio C Hamano <gitster@pobox.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Bradley M. Kuhn" <bkuhn@sfconservancy.org>,
"Brandon Casey" <drafnel@gmail.com>,
"Shourya Shukla" <periperidip@gmail.com>,
"Christian Couder" <christian.couder@gmail.com>,
"Rafael Silva" <rafaeloliveira.cs@gmail.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 2/2] [GSOC] interpret-trailer: easy parse trailer value
Date: Sun, 21 Mar 2021 06:57:06 -0700 [thread overview]
Message-ID: <xmqq5z1kd2z1.fsf@gitster.g> (raw)
In-Reply-To: CAOLTT8Q7yNscYrYHWJQcsGn67MjWe15nd7SnCEd5QVUG0A6dRg@mail.gmail.com
ZheNing Hu <adlternative@gmail.com> writes:
> Do you think this is appropriate?
>
> @@ -370,5 +370,15 @@ int parse_buffer_signed_by_header(const char *buffer,
> struct strbuf *payload,
> struct strbuf *signature,
> const struct git_hash_algo *algop);
> +/*
> + * Calling `find_author_by_nickname` to find the "author <email>" pair
> + * in the most recent commit which matches "--author=name".
> + *
> + * Note that `find_author_by_nickname` is not reusable, because it haven't
> + * reset flags for parsed objects. The only safe way to use
> `find_author_by_nickname`
> + * (without rewriting the revision traversal machinery) is to spawn a
> + * subprocess and do find_author_by_nickname() in it.
> + */
Telling people not to add any new caller is good, but everything
after "because" does not make sense to me.
I do not think calling find_author_by_nickname() in a subprocess
alone would not help somebody who wants to do this, either. We'd be
doing a moral equivalent of that call, but the result has to be
communicated back to the parent process,
In the longer term, we'd probably want to have a pre-computed table
of contributors, like we have precomputed files for reachability
bitmaps, commit DAG topology, and such, but that is obviously far
outside of the scope of this series.
> +const char *find_author_by_nickname(const char *name);
next prev parent reply other threads:[~2021-03-21 13:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 14:41 [PATCH 0/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 21:06 ` Junio C Hamano
2021-03-21 3:29 ` ZheNing Hu
2021-03-21 13:57 ` Junio C Hamano [this message]
2021-03-21 14:12 ` ZheNing Hu
2021-03-21 8:58 ` [PATCH v2 0/2] " ZheNing Hu via GitGitGadget
2021-03-21 8:58 ` [PATCH v2 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-21 8:58 ` [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-21 9:17 ` Bagas Sanjaya
2021-03-21 14:04 ` ZheNing Hu
2021-03-21 16:49 ` Junio C Hamano
2021-03-22 6:01 ` Bagas Sanjaya
2021-03-22 18:45 ` Junio C Hamano
2021-03-21 13:15 ` Christian Couder
2021-03-21 13:49 ` ZheNing Hu
2021-03-21 16:52 ` Junio C Hamano
2021-03-22 0:39 ` ZheNing Hu
2021-03-22 7:26 ` Christian Couder
2021-03-22 8:28 ` ZheNing Hu
2021-03-22 17:07 ` Junio C Hamano
2021-03-23 5:04 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5z1kd2z1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adlternative@gmail.com \
--cc=avarab@gmail.com \
--cc=bkuhn@sfconservancy.org \
--cc=christian.couder@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
--cc=periperidip@gmail.com \
--cc=rafaeloliveira.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).