git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>,
	"Bradley M. Kuhn" <bkuhn@sfconservancy.org>,
	"Brandon Casey" <drafnel@gmail.com>,
	"Shourya Shukla" <periperidip@gmail.com>,
	"Christian Couder" <christian.couder@gmail.com>,
	"Rafael Silva" <rafaeloliveira.cs@gmail.com>,
	"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
	"Jeff King" <peff@peff.net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"ZheNing Hu" <adlternative@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value
Date: Mon, 22 Mar 2021 11:45:17 -0700	[thread overview]
Message-ID: <xmqq5z1j6n9e.fsf@gitster.g> (raw)
In-Reply-To: <47e8a13f-ce96-f3f3-0f8e-efd685f58e60@gmail.com> (Bagas Sanjaya's message of "Mon, 22 Mar 2021 13:01:58 +0700")

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> I mean the error should be:
>
> ```
> error: @batman match multiple identities:
> 1) batman <email1>
> 2) batman <email2>
> ...
> n) batman <emailn>
>
> Please disambiguate by running "git commit --trailer" with full identity, like:
>     git commit --trailer="<someone> <<email>>" <options>...
>
> ```

Detecting error alone is probably prohibitively expensive, as it
takes you to scan _all_ commits down to the beginning of time to
pruve that a given pattern matches one and only one author ident.

Assuming that we would pay that cost (I doubt we would want to,
though), additional cost to show all possible hits would be small
and manageable, I think.


  reply	other threads:[~2021-03-22 18:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 14:41 [PATCH 0/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 21:06   ` Junio C Hamano
2021-03-21  3:29     ` ZheNing Hu
2021-03-21 13:57       ` Junio C Hamano
2021-03-21 14:12         ` ZheNing Hu
2021-03-21  8:58 ` [PATCH v2 0/2] " ZheNing Hu via GitGitGadget
2021-03-21  8:58   ` [PATCH v2 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-21  8:58   ` [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-21  9:17     ` Bagas Sanjaya
2021-03-21 14:04       ` ZheNing Hu
2021-03-21 16:49       ` Junio C Hamano
2021-03-22  6:01         ` Bagas Sanjaya
2021-03-22 18:45           ` Junio C Hamano [this message]
2021-03-21 13:15     ` Christian Couder
2021-03-21 13:49       ` ZheNing Hu
2021-03-21 16:52       ` Junio C Hamano
2021-03-22  0:39         ` ZheNing Hu
2021-03-22  7:26           ` Christian Couder
2021-03-22  8:28             ` ZheNing Hu
2021-03-22 17:07           ` Junio C Hamano
2021-03-23  5:04             ` ZheNing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5z1j6n9e.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=adlternative@gmail.com \
    --cc=avarab@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=bkuhn@sfconservancy.org \
    --cc=christian.couder@gmail.com \
    --cc=congdanhqx@gmail.com \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=peff@peff.net \
    --cc=periperidip@gmail.com \
    --cc=rafaeloliveira.cs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).