git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	git@vger.kernel.org, "Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Barret Rhoden" <brho@google.com>,
	"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
	"Rafael Silva" <rafaeloliveira.cs@gmail.com>,
	"Matheus Tavares" <matheus.bernardino@usp.br>
Subject: Re: [PATCH v3 3/3] git-worktree.txt: fix typo in example path
Date: Mon, 28 Jun 2021 18:12:42 -0700	[thread overview]
Message-ID: <xmqq5yxx4gol.fsf@gitster.g> (raw)
In-Reply-To: 8da4cb97-eb46-1ce5-ee74-fb1286d230aa@gmail.com

Andrei Rybak <rybak.a.v@gmail.com> writes:

> On 26/06/2021 08:58, Carlo Marcelo Arenas Belón wrote:
>> not sure if this patch really belongs in this specific patchset
>
> Yes, third patch is unrelated to the first two.
>
>>, but it
>> might be worth also fixing the same typo in grep as shown by :
>> --- >8 ---
>> Subject: grep: fix worktree mis spelling
>
> s/mis spelling/misspelling/
>
>> 1d1729caeb (grep: replace grep_read_mutex by internal obj read lock,
>>   2020-01-15) adds it as part of a comment
>> fix it to the right spelling without the extra trailing 'e'.
>> diff --git a/grep.c b/grep.c
>> index 8f91af1cb0..f40c734565 100644
>> --- a/grep.c
>> +++ b/grep.c
>> @@ -1510,7 +1510,7 @@ static int fill_textconv_grep(struct repository *r,
>>   	 *
>>   	 * TODO: allowing text conversion to run in parallel with object
>>   	 * reading operations might increase performance in the multithreaded
>> -	 * non-worktreee git-grep with --textconv.
>> +	 * non-worktree git-grep with --textconv.
>
> I deliberately skipped this typo, because it is in a TODO comment, which
> I thought isn't worth fixing. I probably should have mentioned that in
> the patch I've sent.

All sound sensible.  Will queue these three patches as-is.

Thanks.

  reply	other threads:[~2021-06-29  1:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 22:11 [PATCH] blame: fix typo in documentation Andrei Rybak
2021-06-19  5:27 ` Bagas Sanjaya
2021-06-19 11:12   ` Andrei Rybak
2021-06-19 11:20     ` Bagas Sanjaya
2021-06-19 17:31   ` Felipe Contreras
2021-06-19 11:29 ` [PATCH v2] blame: correct name of config option in docs Andrei Rybak
2021-06-20  9:37   ` Bagas Sanjaya
2021-06-21 16:57     ` Barret Rhoden
2021-06-25 19:38   ` [PATCH v3 0/3] Config option names typofixes Andrei Rybak
2021-06-25 19:38     ` [PATCH v3 1/3] blame: correct name of config option in docs Andrei Rybak
2021-06-25 19:38     ` [PATCH v3 2/3] t: fix typos in test messages Andrei Rybak
2021-06-25 19:38     ` [PATCH v3 3/3] git-worktree.txt: fix typo in example path Andrei Rybak
2021-06-26  6:58       ` Carlo Marcelo Arenas Belón
2021-06-26 10:07         ` Andrei Rybak
2021-06-29  1:12           ` Junio C Hamano [this message]
2021-06-26 11:50     ` [PATCH v3 0/3] Config option names typofixes Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5yxx4gol.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bagasdotme@gmail.com \
    --cc=brho@google.com \
    --cc=carenas@gmail.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=matheus.bernardino@usp.br \
    --cc=rafaeloliveira.cs@gmail.com \
    --cc=rybak.a.v@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).