git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: "Git List" <git@vger.kernel.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] t4202: fix patternType setting in --invert-grep test
Date: Fri, 17 Dec 2021 16:14:56 -0800	[thread overview]
Message-ID: <xmqq5yrm22gv.fsf@gitster.g> (raw)
In-Reply-To: <79dcebc0-e569-cc8a-4702-c572b062ed6d@web.de> ("René Scharfe"'s message of "Fri, 17 Dec 2021 17:48:52 +0100")

René Scharfe <l.s.r@web.de> writes:

> Actually use extended regexes as indicated in the comment.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  t/t4202-log.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4202-log.sh b/t/t4202-log.sh
> index 7884e3d46b..f51b57b4a2 100755
> --- a/t/t4202-log.sh
> +++ b/t/t4202-log.sh
> @@ -250,7 +250,7 @@ test_expect_success 'log --invert-grep --grep' '
>  	test_cmp expect actual &&
>
>  	# POSIX extended
> -	git -c grep.patternType=basic log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual &&
> +	git -c grep.patternType=extended log --pretty="tformat:%s" --invert-grep --grep=t[h] --grep=S[e]c >actual &&
>  	test_cmp expect actual &&

Good eyes.

Thanks.

      reply	other threads:[~2021-12-18  0:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 16:48 [PATCH] t4202: fix patternType setting in --invert-grep test René Scharfe
2021-12-18  0:14 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5yrm22gv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).