From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Neeraj Singh <neerajsi@microsoft.com>,
Han Xin <chiyutianyi@gmail.com>
Subject: Re: [PATCH v3] trace2: only include "fsync" events if we git_fsync()
Date: Mon, 18 Jul 2022 09:50:45 -0700 [thread overview]
Message-ID: <xmqq5yjus6u2.fsf@gitster.g> (raw)
In-Reply-To: <patch-v3-1.1-979dea5956a-20220718T102747Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 18 Jul 2022 12:31:52 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> As we're needing to indent the trace2_data_intmax() lines let's
> introduce helper variables to ensure that our resulting lines (which
> were already too) don't exceed the recommendations of the
> CodingGuidelines. Doing that requires either wrapping them twice, or
> introducing short throwaway variable names, let's do the latter.
Or a macro that can be used like
log_trace_fsync_nonzero(writeout_only);
log_trace_fsync_nonzero(hardware_flush);
something along the lines of
#define log_trace_fsync_nonzero(var) \
if (count_fsync_ #var) \
trace2_data_intmax("fsync", the_repository, \
"fsync/" ##var, count_fsync_ #var)
using token pasting and token stringification ;-)
The macro itself I am not serious at all. s/_if/_nonzero/ may be
worth pondering, though.
> We now test how many "writeout" and "flush" sync events we emit,
> rather than the (meaningless) previous behavior (see above)>
Makes sense.
Neeraj, Ack, as the author of 9a498767 (trace2: add stats for fsync
operations, 2022-03-30)?
Thanks all.
next prev parent reply other threads:[~2022-07-18 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 15:51 [PATCH] trace2: don't include "fsync" events in all trace2 logs Ævar Arnfjörð Bjarmason
2022-06-23 18:21 ` [EXTERNAL] " Neeraj Singh (WINDOWS-SFS)
2022-06-23 19:34 ` Junio C Hamano
2022-06-30 8:56 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-06-30 20:45 ` Junio C Hamano
2022-07-18 10:31 ` [PATCH v3] trace2: only include "fsync" events if we git_fsync() Ævar Arnfjörð Bjarmason
2022-07-18 16:50 ` Junio C Hamano [this message]
2022-07-18 19:01 ` [EXTERNAL] " Neeraj Singh (WINDOWS-SFS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5yjus6u2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chiyutianyi@gmail.com \
--cc=git@vger.kernel.org \
--cc=neerajsi@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).