From: Junio C Hamano <gitster@pobox.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH v2] test-lib: drop comment about test_description
Date: Sat, 25 Feb 2023 14:50:08 -0800 [thread overview]
Message-ID: <xmqq5ybpuzq7.fsf@gitster.g> (raw)
In-Reply-To: 20230225190526.21780-1-rybak.a.v@gmail.com
Andrei Rybak <rybak.a.v@gmail.com> writes:
> ... The assignment
> of "test_description" and the process of writing tests in general are
> described in detail in "t/README". So drop the obsolete comment.
Sounds sensible.
> An alternative solution is to move the comment down to the usage of
> variable "test_description".
Or at the beginning, as the comment is about "how you can use this
test-lib.sh test library in your tests".
I have no strong preference. Just dropping it sounds easier, as a
more readable description already exists elsewhere.
> t/test-lib.sh | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index d272cca008..62136caee5 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -645,12 +645,6 @@ u200c=$(printf '\342\200\214')
>
> export _x05 _x35 LF u200c EMPTY_TREE EMPTY_BLOB ZERO_OID OID_REGEX
>
> -# Each test should start with something like this, after copyright notices:
> -#
> -# test_description='Description of this test...
> -# This test checks if command xyzzy does the right thing...
> -# '
> -# . ./test-lib.sh
> test "x$TERM" != "xdumb" && (
> test -t 1 &&
> tput bold >/dev/null 2>&1 &&
next prev parent reply other threads:[~2023-02-25 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 23:22 [RFC PATCH v1] test-lib: move comment about test_description Andrei Rybak
2023-02-25 19:05 ` [RFC PATCH v2] test-lib: drop " Andrei Rybak
2023-02-25 22:50 ` Junio C Hamano [this message]
2023-02-26 10:53 ` [PATCH v3] " Andrei Rybak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5ybpuzq7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).