git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Andrei Rybak <rybak.a.v@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t5000: use check_mtime()
Date: Mon, 27 Mar 2023 15:45:26 -0700	[thread overview]
Message-ID: <xmqq5yaln795.fsf@gitster.g> (raw)
In-Reply-To: <a47f8172-a8d0-abe8-09a8-f31b9e19b1a1@web.de> ("René Scharfe"'s message of "Mon, 27 Mar 2023 19:59:56 +0200")

René Scharfe <l.s.r@web.de> writes:

> Care to send a patch?
>
> There's more by the way:
> ...
> Personally I'd like to avoid wasting space and the second form looks odd
> to me, which turned me into a repeat offender out of negligence, I
> guess.  Anyway, since we have a documented rule (that came about by
> majority vote of code lines IIUC) we should follow it.

I used to appreciate that I can grep for "func (" to find shell
function definition while I can grep for "func(" for C, but that was
a long time ago.  "git grep <pattern> --" followed by "\*.c" vs "\*.sh"
is what I use to limit the hits these days anyway ;-)

      reply	other threads:[~2023-03-27 22:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-25 12:16 [PATCH] t5000: use check_mtime() René Scharfe
2023-03-26 12:53 ` Andrei Rybak
2023-03-27 17:59   ` René Scharfe
2023-03-27 22:45     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5yaln795.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=rybak.a.v@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).