From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <nasamuffin@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] usage: clarify --recurse-submodules as a boolean
Date: Fri, 05 May 2023 10:30:27 -0700 [thread overview]
Message-ID: <xmqq5y96ele4.fsf@gitster.g> (raw)
In-Reply-To: <xmqqfs97cozz.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 10 Apr 2023 16:10:40 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Emily Shaffer <nasamuffin@google.com> writes:
>
>> `git switch` `git checkout`, `git reset`, and `git read-tree` allow a
>
> Missing comma?
>
>> user to choose to recurse into submodules. All four of these commands'
>> short usage seems to indicate that `--recurse-submodules` should take an
>> argument. In practice, though, all four of these commands parse through
>> the same callback path:
>>
>> option_parse_recurse_submodules_worktree_updater(...) checks for
>> set/unset, or passes off to...
>> parse_update_recurse_submodules_arg(...), which is a straight handoff
>> to...
>> parse_update_recurse(...), which only accepts true or false.
>
> "true or false" -> "various forms of 'true' (e.g. on/1/yes) or 'false'"
>
>> So ultimately, it can only be true or false, unlike `git push
>
> Likewise. Here is a minimally touched up version I queued.
>
> Thanks.
> ...
Any updates on this topic?
prev parent reply other threads:[~2023-05-05 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 22:18 [PATCH] usage: clarify --recurse-submodules as a boolean Emily Shaffer
2023-04-07 23:47 ` Junio C Hamano
2023-04-08 0:03 ` Junio C Hamano
2023-04-08 0:22 ` Emily Shaffer
2023-04-08 0:59 ` Junio C Hamano
2023-04-10 16:41 ` Emily Shaffer
2023-04-08 0:07 ` Emily Shaffer
2023-04-10 23:07 ` Junio C Hamano
2023-04-10 22:52 ` [PATCH v2] " Emily Shaffer
2023-04-10 23:10 ` Junio C Hamano
2023-05-05 17:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5y96ele4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nasamuffin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).