What's cooking in git.git (Apr 2014, #01; Fri, 4)

What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Junio C Hamano]

Here are the topics that have been cooking.  Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.

More topics merged to 'master', some of which are fallouts from GSoC
microprojects, some are updates to docs.  C/C++ funcname pattern
update is now in.

I haven't reverted the merge of that "submodule update" topic yet; I
should do that soonish.

You can find the changes described here in the integration branches
of the repositories listed at

    http://git-blame.blogspot.com/p/git-public-repositories.html

--------------------------------------------------
[Graduated to "master"]

* ap/remote-hg-skip-null-bookmarks (2014-03-25) 1 commit
  (merged to 'next' on 2014-03-25 at a8cd922)
 + remote-hg: do not fail on invalid bookmarks


* cb/aix (2014-03-31) 2 commits
  (merged to 'next' on 2014-04-01 at dd6b3d8)
 + tests: don't rely on strerror text when testing rmdir failure
 + dir.c: make git_fnmatch() not inline


* cn/fetch-prune-overlapping-destination (2014-03-26) 2 commits
  (merged to 'next' on 2014-03-28 at 954513a)
 + fetch: handle overlaping refspecs on --prune
 + fetch: add a failing test for prunning with overlapping refspecs

 Protect refs in a hierarchy that can come from more than one remote
 hierarcies from incorrect removal by "git fetch --prune".


* ep/shell-command-substitution (2014-03-25) 2 commits
  (merged to 'next' on 2014-03-28 at 99a512a)
 + git-am.sh: use the $(...) construct for command substitution
 + check-builtins.sh: use the $(...) construct for command substitution


* jc/fix-diff-no-index-diff-opt-parse (2014-03-31) 1 commit
  (merged to 'next' on 2014-04-01 at b8ae26b)
 + diff-no-index: correctly diagnose error return from diff_opt_parse()

 "diff --no-index -Mq a b" fell into an infinite loop.


* nd/gc-aggressive (2014-03-31) 2 commits
  (merged to 'next' on 2014-04-01 at e9f89b3)
 + environment.c: fix constness for odb_pack_keep()
 + gc --aggressive: make --depth configurable

 Allow tweaking the maximum length of the delta-chain produced by
 "gc --aggressive".


* nd/log-show-linear-break (2014-03-25) 2 commits
  (merged to 'next' on 2014-03-28 at ea4a8db)
 + log: add --show-linear-break to help see non-linear history
 + object.h: centralize object flag allocation

 Attempts to show where a single-strand-of-pearls break in "git log"
 output.


* rs/pickaxe-i (2014-03-24) 10 commits
  (merged to 'next' on 2014-03-25 at 3b6f21f)
 + pickaxe: simplify kwset loop in contains()
 + pickaxe: call strlen only when necessary in diffcore_pickaxe_count()
 + pickaxe: move pickaxe() after pickaxe_match()
 + pickaxe: merge diffcore_pickaxe_grep() and diffcore_pickaxe_count() into diffcore_pickaxe()
 + pickaxe: honor -i when used with -S and --pickaxe-regex
 + t4209: use helper functions to test --author
 + t4209: use helper functions to test --grep
 + t4209: factor out helper function test_log_icase()
 + t4209: factor out helper function test_log()
 + t4209: set up expectations up front

 Allow the options -i/--regexp-ignore-case, --pickaxe-regex, and -S
 to be used together and work as expected to perform a pickaxe
 search using case-insensitive regular expression matching.

--------------------------------------------------
[New Topics]

* ib/rev-parse-parseopt-argh (2014-04-01) 1 commit
  (merged to 'next' on 2014-04-01 at 025578d)
 + rev-parse: fix typo in example on manpage

 Finishing touch to a new topic scheduled for 2.0

 Will merge to 'master'.


* mh/lockfile (2014-04-02) 22 commits
 - lockfile: allow new file contents to be written while retaining lock
 - lockfile: extract a function reset_lock_file()
 - remove_lock_file(): call rollback_lock_file()
 - struct lock_file: rename lock_filename field to staging_filename
 - lockfile: also keep track of the filename of the file being locked
 - lock_file(): exit early if lockfile cannot be opened
 - commit_lock_file(): don't work with a fixed-length buffer
 - resolve_symlink(): use a strbuf internally
 - lockfile: use strbufs when handling (most) paths
 - config: change write_error() to take a (struct lock_file *) argument
 - delete_ref_loose(): don't muck around in the lock_file's filename
 - lockfile: define a constant LOCK_SUFFIX_LEN
 - lockfile.c: document the various states of lock_file objects
 - api-lockfile: expand the documentation
 - struct lock_file: replace on_list field with flags field
 - lock_file(): always add lock_file object to lock_file_list
 - hold_lock_file_for_append(): release lock on errors
 - lockfile: unlock file if lockfile permissions cannot be adjusted
 - rollback_lock_file(): set fd to -1
 - rollback_lock_file(): do not clear filename redundantly
 - try_merge_strategy(): remove redundant lock_file allocation
 - t3204: test deleting references when lock files already exist


* mh/update-ref-batch-create-fix (2014-04-02) 1 commit
  (merged to 'next' on 2014-04-04 at 97e3f12)
 + update-ref: fail create operation over stdin if ref already exists

 Will merge to 'master'.


* jk/pack-bitmap (2014-04-04) 1 commit
 - add `ignore_missing_links` mode to revwalk

 Will merge to 'next'.

--------------------------------------------------
[Stalled]

* tr/merge-recursive-index-only (2014-02-05) 3 commits
 - merge-recursive: -Xindex-only to leave worktree unchanged
 - merge-recursive: internal flag to avoid touching the worktree
 - merge-recursive: remove dead conditional in update_stages()
 (this branch is used by tr/remerge-diff.)

 Will hold.


* tr/remerge-diff (2014-02-26) 5 commits
 . log --remerge-diff: show what the conflict resolution changed
 . name-hash: allow dir hashing even when !ignore_case
 . merge-recursive: allow storing conflict hunks in index
 . revision: fold all merge diff variants into an enum merge_diff_mode
 . combine-diff: do not pass revs->dense_combined_merges redundantly
 (this branch uses tr/merge-recursive-index-only.)

 "log -p" output learns a new way to let users inspect a merge
 commit by showing the differences between the automerged result
 with conflicts the person who recorded the merge would have seen
 and the final conflict resolution that was recorded in the merge.

 Needs to be rebased, now kb/fast-hashmap topic is in.


* sz/mingw-index-pack-threaded (2014-03-19) 1 commit
 - Enable index-pack threading in msysgit.

 What is the status of this topic?  A failure report exists
 ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
 where the discussion stalled.  Is everybody waiting for everybody
 else to get the discussion unstuck?


* bc/blame-crlf-test (2014-02-18) 1 commit
 - blame: add a failing test for a CRLF issue.

 I have a feeling that a fix for this should be fairly isolated and
 trivial (it should be just the matter of paying attention to the
 crlf settings when synthesizing the fake commit)---perhaps somebody
 can squash in a fix to this?


* jk/makefile (2014-02-05) 16 commits
 - FIXUP
 - move LESS/LV pager environment to Makefile
 - Makefile: teach scripts to include make variables
 - FIXUP
 - Makefile: auto-build C strings from make variables
 - Makefile: drop *_SQ variables
 - FIXUP
 - Makefile: add c-quote helper function
 - Makefile: introduce sq function for shell-quoting
 - Makefile: always create files via make-var
 - Makefile: store GIT-* sentinel files in MAKE/
 - Makefile: prefer printf to echo for GIT-*
 - Makefile: use tempfile/mv strategy for GIT-*
 - Makefile: introduce make-var helper function
 - Makefile: fix git-instaweb dependency on gitweb
 - Makefile: drop USE_GETTEXT_SCHEME from GIT-CFLAGS

 Simplify the Makefile rules and macros that exist primarily for
 quoting purposes, and make it easier to robustly express the
 dependency rules.

 Expecting a reroll.


* po/everyday-doc (2014-01-27) 1 commit
 - Make 'git help everyday' work

 This may make the said command to emit something, but the source is
 not meant to be formatted into a manual pages to begin with, and
 also its contents are a bit stale.  It may be a good first step in
 the right direction, but needs more work to at least get the
 mark-up right before public consumption.

 Will hold.


* jk/branch-at-publish-rebased (2014-01-17) 5 commits
 - t1507 (rev-parse-upstream): fix typo in test title
 - implement @{publish} shorthand
 - branch_get: provide per-branch pushremote pointers
 - branch_get: return early on error
 - sha1_name: refactor upstream_mark

 Give an easier access to the tracking branches from "other" side in
 a triangular workflow by introducing B@{publish} that works in a
 similar way to how B@{upstream} does.

 Meant to be used as a basis for whatever Ram wants to build on.

 Will hold.


* rb/merge-prepare-commit-msg-hook (2014-01-10) 4 commits
 - merge: drop unused arg from abort_commit method signature
 - merge: make prepare_to_commit responsible for write_merge_state
 - t7505: ensure cleanup after hook blocks merge
 - t7505: add missing &&

 Expose more merge states (e.g. $GIT_DIR/MERGE_MODE) to hooks that
 run during "git merge".  The log message stresses too much on one
 hook, prepare-commit-msg, but it would equally apply to other hooks
 like post-merge, I think.

 Waiting for a reroll.


* jl/submodule-recursive-checkout (2013-12-26) 5 commits
 - Teach checkout to recursively checkout submodules
 - submodule: teach unpack_trees() to update submodules
 - submodule: teach unpack_trees() to repopulate submodules
 - submodule: teach unpack_trees() to remove submodule contents
 - submodule: prepare for recursive checkout of submodules

 Expecting a reroll.


* jc/graph-post-root-gap (2013-12-30) 3 commits
 - WIP: document what we want at the end
 - graph: remove unused code a bit
 - graph: stuff the current commit into graph->columns[]

 This was primarily a RFH ($gmane/239580).


* np/pack-v4 (2013-09-18) 90 commits
 . packv4-parse.c: add tree offset caching
 . t1050: replace one instance of show-index with verify-pack
 . index-pack, pack-objects: allow creating .idx v2 with .pack v4
 . unpack-objects: decode v4 trees
 . unpack-objects: allow to save processed bytes to a buffer
 - ...

 Nico and Duy advancing the eternal vaporware pack-v4.  This is here
 primarily for wider distribution of the preview edition.

 Needs to be rebased, now the pack-bitmap series is in.


* tg/perf-lib-test-perf-cleanup (2013-09-19) 2 commits
 - perf-lib: add test_perf_cleanup target
 - perf-lib: split starting the test from the execution

 Add test_perf_cleanup shell function to the perf suite, that allows
 the script writers to define a test with a clean-up action.

 Will hold.


* jc/format-patch (2013-04-22) 2 commits
 - format-patch: --inline-single
 - format-patch: rename "no_inline" field

 A new option to send a single patch to the standard output to be
 appended at the bottom of a message.  I personally have no need for
 this, but it was easy enough to cobble together.  Tests, docs and
 stripping out more MIMEy stuff are left as exercises to interested
 parties.


* jc/show-branch (2014-03-24) 5 commits
 - show-branch: use commit slab to represent bitflags of arbitrary width
 - show-branch.c: remove "all_mask"
 - show-branch.c: abstract out "flags" operation
 - show-branch.c: lift all_mask/all_revs to a global static
 - show-branch.c: update comment style

 Waiting for the final step to lift the hard-limit before sending it out.

--------------------------------------------------
[Cooking]

* mr/opt-set-ptr (2014-03-31) 3 commits
  (merged to 'next' on 2014-04-03 at a26385b)
 + parse-options: remove unused OPT_SET_PTR
 + parse-options: add cast to correct pointer type to OPT_SET_PTR
 + MSVC: fix t0040-parse-options crash

 OPT_SET_PTR() implementation was broken on IL32P64 platforms;
 it turns out that the macro is not used by any real user.


* mt/patch-id-stable (2014-03-31) 3 commits
 - patch-id-test: test --stable and --unstable flags
 - patch-id: document new behaviour
 - patch-id: make it stable against hunk reordering

 Introduce a new way to compute patch-id for a patch that is not
 affected by the order of the paths that appear in the input.

 Will merge to 'next' and keep it there for the remainder of this cycle.


* jl/nor-or-nand-and (2014-03-31) 4 commits
 - code and test: fix misuses of "nor"
 - comments: fix misuses of "nor"
 - contrib: fix misuses of "nor"
 - Documentation: fix misuses of "nor"

 Eradicate mistaken use of "nor" (that is, essentially "nor" used
 not in "neither A nor B" ;-)) from in-code comments, command output
 strings, and documentations.

 Will merge to 'next'.


* mh/ref-transaction (2014-04-01) 27 commits
 - ref_transaction_commit(): work with transaction->updates in place
 - struct ref_update: add type field
 - struct ref_update: add a lock member
 - ref_transaction_commit(): introduce temporary variables
 - struct ref_update: store refname as a FLEX_ARRAY
 - struct ref_update: rename field "ref_name" to "refname"
 - refs: remove API function update_refs()
 - update-ref --stdin: reimplement using reference transactions
 - refs: add a concept of a reference transaction
 - update-ref --stdin: harmonize error messages
 - update-ref --stdin: improve the error message for unexpected EOF
 - t1400: test one mistake at a time
 - update-ref --stdin -z: deprecate interpreting the empty string as zeros
 - update-ref.c: extract a new function, parse_next_sha1()
 - t1400: test that stdin -z update treats empty <newvalue> as zeros
 - update-ref --stdin: simplify error messages for missing oldvalues
 - update-ref --stdin: make error messages more consistent
 - update-ref --stdin: improve error messages for invalid values
 - update-ref.c: extract a new function, parse_refname()
 - parse_cmd_verify(): copy old_sha1 instead of evaluating <oldvalue> twice
 - update-ref --stdin: read the whole input at once
 - update_refs(): fix constness
 - refs.h: rename the action_on_err constants
 - t1400: add some more tests involving quoted arguments
 - parse_arg(): really test that argument is properly terminated
 - t1400: provide more usual input to the command
 - t1400: fix name and expected result of one test

 Update "update-ref --stdin [-z]" and then introduce a transactional
 support for (multi-)reference updates.

 Replaced with an unpublished "v3".


* jc/apply-ignore-whitespace (2014-03-26) 1 commit
  (merged to 'next' on 2014-04-04 at 53779a7)
 + apply --ignore-space-change: lines with and without leading whitespaces do not match

 "--ignore-space-change" option of "git apply" ignored the
 spaces at the beginning of line too aggressively, which is
 inconsistent with the option of the same name "diff" and "git diff"
 have.

 Will keep in 'next' for the remainder of this cycle.


* jc/rev-parse-argh-dashed-multi-words (2014-03-24) 3 commits
  (merged to 'next' on 2014-03-31 at 1c48649)
 + parse-options: make sure argh string does not have SP or _
 + update-index: teach --cacheinfo a new syntax "mode,sha1,path"
 + parse-options: multi-word argh should use dash to separate words

 Make sure that the help text given to describe the "<param>" part
 of the "git cmd --option=<param>" does not contain SP or _,
 e.g. "--gpg-sign=<key-id>" option for "git commit" is not spelled
 as "--gpg-sign=<key id>".

 Will merge to 'master'.


* jk/commit-dates-parsing-fix (2014-04-01) 2 commits
  (merged to 'next' on 2014-04-04 at c16eeb0)
 + t4212: loosen far-in-future test for AIX
 + date: recognize bogus FreeBSD gmtime output

 Will merge to 'master' and later to 'maint'.


* mr/msvc-link-with-invalidcontinue (2014-03-28) 1 commit
  (merged to 'next' on 2014-03-31 at 051a29e)
 + MSVC: link in invalidcontinue.obj for better POSIX compatibility

 Will merge to 'master'.


* as/grep-fullname-config (2014-03-20) 1 commit
  (merged to 'next' on 2014-03-28 at 810a076)
 + grep: add grep.fullName config variable

 Add a configuration variable to force --full-name to be default for
 "git grep".

 This may cause regressions on scripted users that do not expect
 this new behaviour.

 Will keep in 'next' for the remainder of this cycle.


* nd/multiple-work-trees (2014-03-25) 28 commits
 - count-objects: report unused files in $GIT_DIR/repos/...
 - gc: support prune --repos
 - gc: style change -- no SP before closing bracket
 - prune: strategies for linked checkouts
 - checkout: detach if the branch is already checked out elsewhere
 - checkout: clean up half-prepared directories in --to mode
 - checkout: support checking out into a new working directory
 - use new wrapper write_file() for simple file writing
 - wrapper.c: wrapper to open a file, fprintf then close
 - setup.c: support multi-checkout repo setup
 - setup.c: detect $GIT_COMMON_DIR check_repository_format_gently()
 - setup.c: convert check_repository_format_gently to use strbuf
 - setup.c: detect $GIT_COMMON_DIR in is_git_directory()
 - setup.c: convert is_git_directory() to use strbuf
 - git-stash: avoid hardcoding $GIT_DIR/logs/....
 - *.sh: avoid hardcoding $GIT_DIR/hooks/...
 - git-sh-setup.sh: use rev-parse --git-path to get $GIT_DIR/objects
 - $GIT_COMMON_DIR: a new environment variable
 - commit: use SEQ_DIR instead of hardcoding "sequencer"
 - fast-import: use git_path() for accessing .git dir instead of get_git_dir()
 - reflog: avoid constructing .lock path with git_path
 - *.sh: respect $GIT_INDEX_FILE
 - git_path(): be aware of file relocation in $GIT_DIR
 - path.c: group git_path(), git_pathdup() and strbuf_git_path() together
 - path.c: rename vsnpath() to do_git_path()
 - git_snpath(): retire and replace with strbuf_git_path()
 - path.c: make get_pathname() call sites return const char *
 - path.c: make get_pathname() return strbuf instead of static buffer

 A replacement for contrib/workdir/git-new-workdir that does not
 rely on symbolic links and make sharing of objects and refs safer
 by making the borrowee and borrowers aware of each other.

 Will hold.


* ks/tree-diff-nway (2014-03-27) 19 commits
 - combine-diff: speed it up, by using multiparent diff tree-walker directly
 - tree-diff: rework diff_tree() to generate diffs for multiparent cases as well
 - Portable alloca for Git
  (merged to 'next' on 2014-03-31 at 16a7bd4)
 + tree-diff: reuse base str(buf) memory on sub-tree recursion
 + tree-diff: no need to call "full" diff_tree_sha1 from show_path()
 + tree-diff: rework diff_tree interface to be sha1 based
 + tree-diff: diff_tree() should now be static
 + tree-diff: remove special-case diff-emitting code for empty-tree cases
  (merged to 'next' on 2014-03-25 at cfcbdac)
 + tree-diff: simplify tree_entry_pathcmp
 + tree-diff: show_path prototype is not needed anymore
 + tree-diff: rename compare_tree_entry -> tree_entry_pathcmp
 + tree-diff: move all action-taking code out of compare_tree_entry()
 + tree-diff: don't assume compare_tree_entry() returns -1,0,1
  (merged to 'next' on 2014-03-21 at d872679)
 + tree-diff: consolidate code for emitting diffs and recursion in one place
 + tree-diff: show_tree() is not needed
 + tree-diff: no need to pass match to skip_uninteresting()
 + tree-diff: no need to manually verify that there is no mode change for a path
 + combine-diff: move changed-paths scanning logic into its own function
 + combine-diff: move show_log_first logic/action out of paths scanning

 Instead of running N pair-wise diff-trees when inspecting a
 N-parent merge, find the set of paths that were touched by walking
 N+1 trees in parallel.  These set of paths can then be turned into
 N pair-wise diff-tree results to be processed through rename
 detections and such.  And N=2 case nicely degenerates to the usual
 2-way diff-tree, which is very nice.

 The preparatory steps are all in 'next'.

 Will merge to 'next' and keep it there for the remainder of this cycle.


* cc/interpret-trailers (2014-04-01) 11 commits
 - Documentation: add documentation for 'git interpret-trailers'
 - trailer: add tests for commands in config file
 - trailer: execute command from 'trailer.<name>.command'
 - trailer: add tests for "git interpret-trailers"
 - trailer: add interpret-trailers command
 - trailer: put all the processing together and print
 - trailer: parse trailers from stdin
 - trailer: process command line trailer arguments
 - trailer: read and process config information
 - trailer: process trailers from stdin and arguments
 - trailer: add data structures and basic functions

 A new filter to programatically edit the tail end of the commit log
 messages.

 Will merge to 'next'.

--------------------------------------------------
[Discarded]

* hv/submodule-ignore-fix (2013-12-06) 4 commits
 . disable complete ignorance of submodules for index <-> HEAD diff
 . always show committed submodules in summary after commit
 . teach add -f option for ignored submodules
 . fix 'git add' to skip submodules configured as ignored

 Being reworked in a new topic.


* kb/fast-hashmap-pack-struct (2014-02-24) 1 commit
 . hashmap.h: make sure map entries are tightly packed

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Johannes Sixt]

Am 04.04.2014 22:58, schrieb Junio C Hamano:
> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>  - Enable index-pack threading in msysgit.
> 
>  What is the status of this topic?  A failure report exists
>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>  where the discussion stalled.  Is everybody waiting for everybody
>  else to get the discussion unstuck?

I still have to cross-check Duy's patch. I'll hopefully get to it in the
next days and report back.

-- Hannes

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Torsten Bögershausen]

On 2014-04-05 11.19, Johannes Sixt wrote:
> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>  - Enable index-pack threading in msysgit.
>>
>>  What is the status of this topic?  A failure report exists
>>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>  where the discussion stalled.  Is everybody waiting for everybody
>>  else to get the discussion unstuck?
> 
> I still have to cross-check Duy's patch. I'll hopefully get to it in the
> next days and report back.
> 
> -- Hannes
If this helps the discussion:
----------------------------
commit 03d9d2990b718ef6d859405af399f549c186b4df
Merge: 1b8b51b d84a3da
Author: Junio C Hamano <gitster@pobox.com>
Date:   Fri Apr 4 13:34:56 2014 -0700
----------------------------
looks like this:
grep "not ok" 5302.txt:
not ok 19 - [index v1] 1) stream pack to repository
not ok 21 - [index v1] 3) corrupted delta happily returned wrong data
not ok 24 - [index v1] 6) newly created pack is BAD !
not ok 25 - [index v2] 1) stream pack to repository
not ok 27 - [index v2] 3) corrupted delta happily returned wrong data
not ok 29 - [index v2] 5) pack-objects refuses to reuse corrupted data
not ok 30 - [index v2] 6) verify-pack detects CRC mismatch
-------------------------------------
After reverting 9d66f2d97a97e08ae8d7c86
t5302 passed 3 times of 4 runs.

In the first run a crashing "dd" was reported, but that
was not reproducable.

(And the test log looked like this:)
--------------------
not ok 20 - [index v1] 2) create a stealth corruption in a delta base reference
#       # This test assumes file_101 is a delta smaller than 16 bytes.
#            # It should be against file_100 but we substitute its base for file_099
#            sha1_101=`git hash-object file_101` &&
#            sha1_099=`git hash-object file_099` &&
#            offs_101=`index_obj_offset 1.idx $sha1_101` &&
#            nr_099=`index_obj_nr 1.idx $sha1_099` &&
#            chmod +w ".git/objects/pack/pack-${pack1}.pack" &&
#            dd of=".git/objects/pack/pack-${pack1}.pack" seek=$(($offs_101 + 1)) \
#               if=".git/objects/pack/pack-${pack1}.idx" \
#               skip=$((4 + 256 * 4 + $nr_099 * 24)) \
#               bs=1 count=20 conv=notrunc &&
#            git cat-file blob $sha1_101 > file_101_foo1
not ok 21 - [index v1] 3) corrupted delta happily returned wrong data
#       test -f file_101_foo1 && ! cmp file_101 file_101_foo1

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Philip Oakley]

"Junio C Hamano" <gitster@pobox.com> wrote in message 
news:xmqq4n28q0ad.fsf@gitster.dls.corp.google.com...
> Here are the topics that have been cooking.  ...

> * po/everyday-doc (2014-01-27) 1 commit
> - Make 'git help everyday' work
>
> This may make the said command to emit something, but the source is
> not meant to be formatted into a manual pages to begin with, and
> also its contents are a bit stale.  It may be a good first step in
> the right direction, but needs more work to at least get the
> mark-up right before public consumption.
>
> Will hold.
>

I do plan an update.

For some reason emails to me from git@vger.kernel.org have stopped being 
recieved (I was subscribed), so I'm trying to sort that.

Philip 

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Junio C Hamano]

Johannes Sixt <j6t@kdbg.org> writes:

> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>  - Enable index-pack threading in msysgit.
>> 
>>  What is the status of this topic?  A failure report exists
>>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>  where the discussion stalled.  Is everybody waiting for everybody
>>  else to get the discussion unstuck?
>
> I still have to cross-check Duy's patch. I'll hopefully get to it in the
> next days and report back.

Thanks.

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Johannes Sixt]

Am 05.04.2014 11:19, schrieb Johannes Sixt:
> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>  - Enable index-pack threading in msysgit.
>>
>>  What is the status of this topic?  A failure report exists
>>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>  where the discussion stalled.  Is everybody waiting for everybody
>>  else to get the discussion unstuck?
> 
> I still have to cross-check Duy's patch. I'll hopefully get to it in the
> next days and report back.

The test suite passes with Duy's patch ($gmane/245034), but t5302 fails
with this patch with a MinGW build. The patches touch the Cygwin
configuration, but I cannot test a Cygwin build.

I have, however, lost track of what the objective of these patches is.
Is the threaded version significantly faster, and these patches are
worth it?

-- Hannes

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Ramsay Jones]

On 07/04/14 19:35, Johannes Sixt wrote:
> Am 05.04.2014 11:19, schrieb Johannes Sixt:
>> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>>  - Enable index-pack threading in msysgit.
>>>
>>>  What is the status of this topic?  A failure report exists
>>>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>>  where the discussion stalled.  Is everybody waiting for everybody
>>>  else to get the discussion unstuck?
>>
>> I still have to cross-check Duy's patch. I'll hopefully get to it in the
>> next days and report back.
> 
> The test suite passes with Duy's patch ($gmane/245034), but t5302 fails
> with this patch with a MinGW build. The patches touch the Cygwin
> configuration, but I cannot test a Cygwin build.

I haven't tested these on cygwin yet. However, only the old version of
cygwin is affected (newer cygwin has a thread-safe pread) and, since I
no longer have an old installation, I _can't_ test it anyway. :(
(I updated cygwin earlier today and received a brand new cygwin dll
with today's date!).

> I have, however, lost track of what the objective of these patches is.
> Is the threaded version significantly faster, and these patches are
> worth it?

Indeed. I haven't seen any numbers.

ATB,
Ramsay Jones

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Duy Nguyen]

On Tue, Apr 8, 2014 at 1:35 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> Am 05.04.2014 11:19, schrieb Johannes Sixt:
>> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>>  - Enable index-pack threading in msysgit.
>>>
>>>  What is the status of this topic?  A failure report exists
>>>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>>  where the discussion stalled.  Is everybody waiting for everybody
>>>  else to get the discussion unstuck?
>>
>> I still have to cross-check Duy's patch. I'll hopefully get to it in the
>> next days and report back.
>
> The test suite passes with Duy's patch ($gmane/245034), but t5302 fails
> with this patch with a MinGW build.

Is "this patch" the one on 'pu', or mine?

> The patches touch the Cygwin configuration, but I cannot test a Cygwin build.

If no one can test the Cygwin changes, I'm happy to revert it back for safety.

> I have, however, lost track of what the objective of these patches is.
> Is the threaded version significantly faster, and these patches are
> worth it?

It depends on the repo, how much deltas it has, how deep. According to
b8a2486 (index-pack: support multithreaded delta resolving -
2012-05-06), going to two cores saves ~20% time. But some actual
numbers on Windows would be nice.
-- 
Duy

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Torsten Bögershausen]

On 04/07/2014 09:42 PM, Ramsay Jones wrote:
> On 07/04/14 19:35, Johannes Sixt wrote:
>> Am 05.04.2014 11:19, schrieb Johannes Sixt:
>>> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>>>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>>>   - Enable index-pack threading in msysgit.
>>>>
>>>>   What is the status of this topic?  A failure report exists
>>>>   ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>>>   where the discussion stalled.  Is everybody waiting for everybody
>>>>   else to get the discussion unstuck?
>>> I still have to cross-check Duy's patch. I'll hopefully get to it in the
>>> next days and report back.
>> The test suite passes with Duy's patch ($gmane/245034), but t5302 fails
>> with this patch with a MinGW build. The patches touch the Cygwin
>> configuration, but I cannot test a Cygwin build.
> I haven't tested these on cygwin yet. However, only the old version of
> cygwin is affected (newer cygwin has a thread-safe pread) and, since I
> no longer have an old installation, I _can't_ test it anyway. :(
> (I updated cygwin earlier today and received a brand new cygwin dll
> with today's date!).
>
>> I have, however, lost track of what the objective of these patches is.
>> Is the threaded version significantly faster, and these patches are
>> worth it?
> Indeed. I haven't seen any numbers.
>
> ATB,
> Ramsay Jones
>
CYGWIN:
I managed to test under cygwin 1.7, commit 
03d9d2990b718ef6d859405af399f549c186b4d:
Test was OK.

MINWW: t5302 failed (same what Johannas reported)
  After reverting 9d66f2d97a97e08ae8d7c86 t5302 passed under MINGW

HTH
/Torsten

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Johannes Sixt]

Am 08.04.2014 02:39, schrieb Duy Nguyen:
> On Tue, Apr 8, 2014 at 1:35 AM, Johannes Sixt <j6t@kdbg.org> wrote:
>> Am 05.04.2014 11:19, schrieb Johannes Sixt:
>>> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>>>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>>>  - Enable index-pack threading in msysgit.
>>>>
>>>>  What is the status of this topic?  A failure report exists
>>>>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>>>  where the discussion stalled.  Is everybody waiting for everybody
>>>>  else to get the discussion unstuck?
>>>
>>> I still have to cross-check Duy's patch. I'll hopefully get to it in the
>>> next days and report back.
>>
>> The test suite passes with Duy's patch ($gmane/245034), but t5302 fails
>> with this patch with a MinGW build.
> 
> Is "this patch" the one on 'pu', or mine?

"This patch" is the one on pu (sz/mingw-index-pack-threaded). I'm sorry
for the confusion.

-- Hannes

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

[Junio C Hamano]

Johannes Sixt <j6t@kdbg.org> writes:

> Am 08.04.2014 02:39, schrieb Duy Nguyen:
>> On Tue, Apr 8, 2014 at 1:35 AM, Johannes Sixt <j6t@kdbg.org> wrote:
>>> Am 05.04.2014 11:19, schrieb Johannes Sixt:
>>>> Am 04.04.2014 22:58, schrieb Junio C Hamano:
>>>>> * sz/mingw-index-pack-threaded (2014-03-19) 1 commit
>>>>>  - Enable index-pack threading in msysgit.
>>>>>
>>>>>  What is the status of this topic?  A failure report exists
>>>>>  ($gmane/245170), and I am aware of Duy's $gmane/245034 but that was
>>>>>  where the discussion stalled.  Is everybody waiting for everybody
>>>>>  else to get the discussion unstuck?
>>>>
>>>> I still have to cross-check Duy's patch. I'll hopefully get to it in the
>>>> next days and report back.
>>>
>>> The test suite passes with Duy's patch ($gmane/245034), but t5302 fails
>>> with this patch with a MinGW build.
>> 
>> Is "this patch" the one on 'pu', or mine?
>
> "This patch" is the one on pu (sz/mingw-index-pack-threaded). I'm sorry
> for the confusion.

... which has been dropped from 'pu'.  So the next step would be
perhaps to queue $gmane/245034 instead and see if it gets the
parallelism Stefan wanted to see in that codepath?

Thanks.