git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Caio Marcelo de Oliveira Filho <cmarcelo@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v2] commit: add commit.signoff config option
Date: Thu, 25 Jun 2015 09:01:21 -0700	[thread overview]
Message-ID: <xmqq4mlv22we.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CADstYCamTxaLnZeYUma6t=KP3Fx2rQH3svqgCYP4WpAR9k_USg@mail.gmail.com> (Caio Marcelo de Oliveira Filho's message of "Thu, 25 Jun 2015 12:19:22 -0300")

Caio Marcelo de Oliveira Filho <cmarcelo@gmail.com> writes:

> A similar concern probably applies to format.signOff option. Would
> be sufficient to add a note about conscious act (like
> format.signOff has) to the config description?

I am generally in negative on automating this.  This is not just you
but makes everybody else's S-o-b less and less meaningful ("Their
tool have ways to add that string randomly, and many of these ways
the user ends up adding that string without even conciously thinking
what they are doing.  Does that string even mean anything anymore?").

One solution might be to make this not a straight-forward boolean,
but an option that superficially takes a string and treats one
specific value as "true" and everything else as "false", e.g.

[commit]
    signoff = "I certify that all my work is licenseable under DCO"

I dunno.

  reply	other threads:[~2015-06-25 16:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 14:50 [PATCH v2] commit: add commit.signoff config option Caio Marcelo de Oliveira Filho
2015-06-25 14:55 ` Junio C Hamano
2015-06-25 15:08   ` Johannes Löthberg
2015-06-25 15:19   ` Caio Marcelo de Oliveira Filho
2015-06-25 16:01     ` Junio C Hamano [this message]
2015-06-25 18:56       ` Matthieu Moy
2015-06-25 16:36 ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4mlv22we.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=cmarcelo@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).