git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH 6/8] git submodule update: have a dedicated helper for cloning
Date: Thu, 04 Feb 2016 13:57:06 -0800	[thread overview]
Message-ID: <xmqq4mdogmvh.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kb-G=GHdtcH323LbHQ4V_azif04eHVuf8Z3gCeb-e=iKQ@mail.gmail.com> (Stefan Beller's message of "Thu, 4 Feb 2016 12:22:28 -0800")

Stefan Beller <sbeller@google.com> writes:

> I do not think that is a better place as not every consumer of module_list
> (and module_list_compute as the nested function) will need to use the
> submodule caching API.

Ah, if that is the case, then OK.

I was imagining that module-list may someday would return a list of
"struct" instances each of which describes a submodule and has .name
and .path fields, or something, instead of just being a "here is the
path to the submodule, go look it up yourself" interface.  But we
are not there (at least not yet--and I am not saying we agreed that
we would eventually want to go there)

  reply	other threads:[~2016-02-04 21:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 17:51 [PATCHv7 0/8] Expose submodule parallelism to the user Stefan Beller
2016-02-02 17:51 ` [PATCH 1/8] submodule-config: keep update strategy around Stefan Beller
2016-02-03 23:09   ` Junio C Hamano
2016-02-04  3:15     ` Jeff King
2016-02-02 17:51 ` [PATCH 2/8] submodule-config: drop check against NULL Stefan Beller
2016-02-03 23:09   ` Junio C Hamano
2016-02-02 17:51 ` [PATCH 3/8] submodule-config: remove name_and_item_from_var Stefan Beller
2016-02-03 23:09   ` Junio C Hamano
2016-02-02 17:51 ` [PATCH 4/8] submodule-config: introduce parse_generic_submodule_config Stefan Beller
2016-02-03 23:09   ` Junio C Hamano
2016-02-03 23:26     ` Stefan Beller
2016-02-04  0:51       ` Junio C Hamano
2016-02-02 17:51 ` [PATCH 5/8] fetching submodules: respect `submodule.fetchJobs` config option Stefan Beller
2016-02-03 23:09   ` Junio C Hamano
2016-02-02 17:51 ` [PATCH 6/8] git submodule update: have a dedicated helper for cloning Stefan Beller
2016-02-03 23:24   ` Junio C Hamano
2016-02-03 23:41     ` Stefan Beller
2016-02-04  0:54       ` Junio C Hamano
2016-02-04 20:22         ` Stefan Beller
2016-02-04 21:57           ` Junio C Hamano [this message]
2016-02-02 17:51 ` [PATCH 7/8] submodule update: expose parallelism to the user Stefan Beller
2016-02-02 17:51 ` [PATCH 8/8] clone: allow an explicit argument for parallel submodule clones Stefan Beller
  -- strict thread matches above, loose matches on Subject: below --
2015-12-14 22:54 [PATCHv6 0/8] Expose submodule parallelism to the user Stefan Beller
2015-12-14 22:54 ` [PATCH 6/8] git submodule update: have a dedicated helper for cloning Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4mdogmvh.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).