From: Junio C Hamano <gitster@pobox.com>
To: Sven Strickroth <sven@cs-ware.de>
Cc: Git List <git@vger.kernel.org>,
Sebastian Schuberth <sschuberth@gmail.com>,
blees@dcon.de
Subject: Re: [PATCH 2/2 V2] MSVC: VS2013 comes with inttypes.h
Date: Tue, 29 Mar 2016 10:35:20 -0700 [thread overview]
Message-ID: <xmqq4mbpyyp3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <56FAB9FD.7080409@cs-ware.de> (Sven Strickroth's message of "Tue, 29 Mar 2016 19:23:09 +0200")
Sven Strickroth <sven@cs-ware.de> writes:
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---
Ah, I didn't finish the comment I started to write here for the
first round. My "Hmph" was meant to be followed by something like
"Compared to 1/2 which clearly described what got changed, this does
not say much to summarize what it did to help readers".
Re-reading the patch text, I tend to agree with you that the title
"comes with inttypes.h" may be sufficient for readers to reason
about the change, and it would not be necessary to explain that we
can lose fallback definitions by including it.
> compat/mingw.h | 2 +-
> compat/vcbuild/include/unistd.h | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/compat/mingw.h b/compat/mingw.h
> index 6b6d695..137f42e 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -415,7 +415,7 @@ int mingw_offset_1st_component(const char *path);
> extern void build_libgit_environment(void);
> extern const char *program_data_config(void);
> #define git_program_data_config program_data_config
> -#ifndef __MINGW64_VERSION_MAJOR
> +#if !defined(__MINGW64_VERSION_MAJOR) && (!defined(_MSC_VER) || _MSC_VER < 1800)
> #define PRIuMAX "I64u"
> #define PRId64 "I64d"
> #else
> diff --git a/compat/vcbuild/include/unistd.h b/compat/vcbuild/include/unistd.h
> index c65c2cd..b7cc48c 100644
> --- a/compat/vcbuild/include/unistd.h
> +++ b/compat/vcbuild/include/unistd.h
> @@ -45,11 +45,15 @@ typedef unsigned long long uintmax_t;
>
> typedef int64_t off64_t;
>
> +#if !defined(_MSC_VER) || _MSC_VER < 1800
> #define INTMAX_MIN _I64_MIN
> #define INTMAX_MAX _I64_MAX
> #define UINTMAX_MAX _UI64_MAX
>
> #define UINT32_MAX 0xffffffff /* 4294967295U */
> +#else
> +#include<inttypes.h>
Somebody lost a SP here, it seems.
> +#endif
>
> #define STDIN_FILENO 0
> #define STDOUT_FILENO 1
next prev parent reply other threads:[~2016-03-29 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 16:27 [PATCH 2/2] MSVC: VS2013 comes with inttypes.h Sven Strickroth
2016-03-29 16:47 ` Junio C Hamano
2016-03-29 17:23 ` [PATCH 2/2 V2] " Sven Strickroth
2016-03-29 17:35 ` Junio C Hamano [this message]
2016-03-30 8:52 ` Sebastian Schuberth
2016-03-30 11:37 ` [PATCH 2/2 V3] MSVC: Use shipped headers instead of fallback definitions Sven Strickroth
2016-03-30 11:40 ` Sebastian Schuberth
2016-03-30 11:42 ` Johannes Schindelin
2016-03-30 18:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mbpyyp3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=blees@dcon.de \
--cc=git@vger.kernel.org \
--cc=sschuberth@gmail.com \
--cc=sven@cs-ware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).