git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
	Brandon Williams <bmwill@google.com>,
	Stefan Beller <sbeller@google.com>,
	Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3 0/4] Hash abstraction
Date: Mon, 13 Nov 2017 13:24:25 +0900	[thread overview]
Message-ID: <xmqq4lpyajra.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171112212854.791179-1-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sun, 12 Nov 2017 21:28:50 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> This is a series proposing a basic abstraction for hash functions.
>
> The full description of the series can be found here:
> https://public-inbox.org/git/20171028181239.59458-1-sandals@crustytoothpaste.net/
>
> At the bottom of this message is the output of git tbdiff between v2 and
> v3.
>
> Changes from v2:
> * Remove inline.
> * Add dummy functions that call die for unknown hash implementation.
> * Move structure definitions to hash.h and include git-compat-util.h in
>   hash.h.
> * Rename current_hash to the_hash_algo.
> * Use repo_set_hash_algo everywhere we set the hash algorithm for a
>   struct repository.

Change for all of the above in this series looked sensible to me.
Thank, will queue.

  parent reply	other threads:[~2017-11-13  4:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-12 21:28 [PATCH v3 0/4] Hash abstraction brian m. carlson
2017-11-12 21:28 ` [PATCH v3 1/4] setup: expose enumerated repo info brian m. carlson
2017-11-12 21:28 ` [PATCH v3 2/4] Add structure representing hash algorithm brian m. carlson
2017-11-12 21:28 ` [PATCH v3 3/4] Integrate hash algorithm support with repo setup brian m. carlson
2017-11-12 21:28 ` [PATCH v3 4/4] Switch empty tree and blob lookups to use hash abstraction brian m. carlson
2017-11-13 18:43   ` Stefan Beller
2017-11-13  4:24 ` Junio C Hamano [this message]
2017-11-22  7:50   ` [PATCH v3 0/4] Hash abstraction Junio C Hamano
2017-11-22 16:57     ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4lpyajra.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sbeller@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).