git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Chen Jingpiao <chenjingpiao@gmail.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [GSoC][PATCH v2] commit: add a commit.signOff config variable
Date: Mon, 05 Feb 2018 11:22:04 -0800	[thread overview]
Message-ID: <xmqq4lmvb5sz.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180205104059.4759-1-chenjingpiao@gmail.com> (Chen Jingpiao's message of "Mon, 5 Feb 2018 18:40:59 +0800")

Chen Jingpiao <chenjingpiao@gmail.com> writes:

> Add the commit.signOff configuration variable to use the -s or --signoff
> option of git commit by default.

This is a rather old topic.  Here is one from 2006:

    https://public-inbox.org/git/Pine.LNX.4.63.0611281426311.30004@wbgn013.biozentrum.uni-wuerzburg.de/

which was referred to in another discussion in late 2008:

    https://public-inbox.org/git/20081227070228.6117@nanako3.lavabit.com/
    https://public-inbox.org/git/7vabaijvxl.fsf@gitster.siamese.dyndns.org/

I am not sure if the reasons why the last effort was retracted still
apply to this round (the world certainly has changed in the past 10
years); it would be good to explain why this time it is different
;-).

Assuming that the new configuration variable is a desirable thing to
add, the change to the code looks OK.  Documentation updates may
need more thought in the light of past discussions, though.

Thanks.

  reply	other threads:[~2018-02-05 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 10:40 [GSoC][PATCH v2] commit: add a commit.signOff config variable Chen Jingpiao
2018-02-05 19:22 ` Junio C Hamano [this message]
2018-02-06  4:37   ` Chen Jingpiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4lmvb5sz.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=chenjingpiao@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).