From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH 0/2] update-index doc: note new caveats in 2.17
Date: Fri, 09 Feb 2018 13:40:05 -0800 [thread overview]
Message-ID: <xmqq4lmpx2oa.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180209210431.409-1-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 9 Feb 2018 21:04:29 +0000")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> When users upgrade to 2.17 they're going to have git yelling at them
> (as my users did) on existing checkouts, with no indication whatsoever
> that it's due to the UC or how to fix it.
Wait. Are you saying that the new warning is "warning" against a
condition that is not an error?
> ... doesn't it only warn under that mode? I.e.:
>
> -"could not open directory '%s'")
> +"core.untrackedCache: could not open directory '%s'")
For example, if it attempts to open a directory which does *not*
have to exist, and sees an error from opendir() due to ENOENT, then
I do not think it should be giving a warning. If we positively know
that a directory should exist there and we cannot open it, of course
we should warn. Also, if we know a directory should be readable
when it exists, then we should be warning when we see an error other
than ENOENT.
So...
next prev parent reply other threads:[~2018-02-09 21:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 0:56 What's cooking in git.git (Jan 2018, #04; Wed, 31) Junio C Hamano
2018-02-01 11:05 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:09 ` Junio C Hamano
2018-02-09 17:06 ` Johannes Schindelin
2018-02-09 18:30 ` Ævar Arnfjörð Bjarmason
2018-02-01 12:11 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:05 ` Junio C Hamano
2018-02-02 19:29 ` Ævar Arnfjörð Bjarmason
2018-02-09 18:37 ` Ævar Arnfjörð Bjarmason
2018-02-09 18:54 ` Junio C Hamano
2018-02-09 21:04 ` [PATCH 0/2] update-index doc: note new caveats in 2.17 Ævar Arnfjörð Bjarmason
2018-02-09 21:40 ` Junio C Hamano [this message]
2018-02-09 22:10 ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04 ` [PATCH 1/2] update-index doc: note a fixed bug in the untracked cache Ævar Arnfjörð Bjarmason
2018-02-09 21:52 ` Junio C Hamano
2018-02-09 22:14 ` Ævar Arnfjörð Bjarmason
2018-02-09 22:50 ` Junio C Hamano
2018-02-09 22:58 ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04 ` [PATCH 2/2] update-index doc: note the caveat with "could not open..." Ævar Arnfjörð Bjarmason
2018-02-10 10:09 ` What's cooking in git.git (Jan 2018, #04; Wed, 31) Duy Nguyen
2018-02-11 14:44 ` Ævar Arnfjörð Bjarmason
2018-02-12 10:04 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4lmpx2oa.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).