From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Clemens Buchacher <drizzd@gmx.net>,
git@vger.kernel.org, manlio.perillo@gmail.com,
johannes.schindelin@gmx.de
Subject: Re: [PATCH 2/2] completion: simplify ls-files filter
Date: Sat, 17 Mar 2018 22:28:32 -0700 [thread overview]
Message-ID: <xmqq4llex88v.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180318012618.32691-1-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Sun, 18 Mar 2018 02:26:18 +0100")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> First, neither 'git ls-files' nor 'git diff-index' produce quite the
> same order as the 'sort' utility does, e.g.:
>
> $ touch foo.c foo-zzz.c
> $ git add foo*
> $ git diff-index --name-only HEAD
> foo-zzz.c
> foo.c
> $ git diff-index --name-only HEAD |sort
> foo.c
> foo-zzz.c
Doesn't this depend on your locale?
$ printf "foo%s\n" .c -zzz.c /c | LC_ALL=C sort
foo-zzz.c
foo.c
foo/c
$ printf "foo%s\n" .c -zzz.c /c | LC_ALL=en_US.UTF-8 sort
foo/c
foo.c
foo-zzz.c
> Second, the output of 'git ls-files' is kind of "block-sorted": if you
> were to invoke it with the options '--cached --modified --others',
> then it will first list all untracked files in order, then all cached
> files in order, and finally all modified files in order.
This is a lot more important consideration.
> I have a short patch series collecting dust somewhere for a long
> while, which pulls a couple more tricks to make git-aware path
> completion faster, but haven't submitted it yet, because it doesn't
> work quite that well when filenames require quoting. Though, arguably
> the current version doesn't work quite that well with quoted filenames
> either, so...
> Will try to dig up those patches.
Thanks.
next prev parent reply other threads:[~2018-03-18 5:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 8:17 [PATCH 1/2] completion: improve ls-files filter performance Clemens Buchacher
2018-03-17 8:17 ` [PATCH 2/2] completion: simplify ls-files filter Clemens Buchacher
2018-03-18 0:16 ` Junio C Hamano
2018-03-18 1:26 ` SZEDER Gábor
2018-03-18 5:28 ` Junio C Hamano [this message]
2018-04-04 7:46 ` [PATCH] completion: improve ls-files filter performance Clemens Buchacher
2018-04-04 16:16 ` Johannes Schindelin
2018-04-16 22:41 ` [PATCH 00/11] completion: path completion improvements: speedup and quoted paths SZEDER Gábor
2018-04-16 22:41 ` [PATCH 01/11] t9902-completion: add tests demonstrating issues with quoted pathnames SZEDER Gábor
2018-04-17 3:48 ` Junio C Hamano
2018-04-17 23:32 ` SZEDER Gábor
2018-04-17 23:41 ` SZEDER Gábor
2018-04-18 1:22 ` Junio C Hamano
2018-04-26 0:25 ` SZEDER Gábor
2018-04-26 2:11 ` Junio C Hamano
2018-05-18 14:17 ` [PATCH 0/2] Test improvements for 'sg/complete-paths' SZEDER Gábor
2018-05-18 14:17 ` [PATCH 1/2] completion: don't return with error from __gitcomp_file_direct() SZEDER Gábor
2018-05-18 14:17 ` [PATCH 2/2] t9902-completion: exercise __git_complete_index_file() directly SZEDER Gábor
2018-05-18 19:25 ` Eric Sunshine
2018-05-21 12:14 ` Johannes Schindelin
2018-05-21 11:35 ` [PATCH 0/2] Test improvements for 'sg/complete-paths' Johannes Schindelin
2018-05-21 12:17 ` Johannes Schindelin
2018-04-18 12:31 ` [PATCH 01/11] t9902-completion: add tests demonstrating issues with quoted pathnames Johannes Schindelin
2018-04-19 19:08 ` SZEDER Gábor
2018-04-16 22:41 ` [PATCH 02/11] completion: move __git_complete_index_file() next to its helpers SZEDER Gábor
2018-04-16 22:41 ` [PATCH 03/11] completion: simplify prefix path component handling during path completion SZEDER Gábor
2018-04-16 22:41 ` [PATCH 04/11] completion: support completing non-ASCII pathnames SZEDER Gábor
2018-04-16 22:41 ` [PATCH 05/11] completion: improve handling quoted paths on the command line SZEDER Gábor
2018-04-16 22:41 ` [PATCH 06/11] completion: let 'ls-files' and 'diff-index' filter matching paths SZEDER Gábor
2018-04-16 22:41 ` [PATCH 07/11] completion: use 'awk' to strip trailing path components SZEDER Gábor
2018-04-16 22:41 ` [PATCH 08/11] t9902-completion: ignore COMPREPLY element order in some tests SZEDER Gábor
2018-04-16 22:41 ` [PATCH 09/11] completion: remove repeated dirnames with 'awk' during path completion SZEDER Gábor
2018-04-16 22:42 ` [PATCH 10/11] completion: improve handling quoted paths in 'git ls-files's output SZEDER Gábor
2018-04-16 22:42 ` [PATCH 11/11] completion: fill COMPREPLY directly when completing paths SZEDER Gábor
2018-03-18 0:13 ` [PATCH 1/2] completion: improve ls-files filter performance Junio C Hamano
2018-03-19 17:12 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4llex88v.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=drizzd@gmx.net \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=manlio.perillo@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).