From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Stefan Beller" <sbeller@google.com>,
"Josh Steadmon" <steadmon@google.com>, git <git@vger.kernel.org>,
"René Scharfe" <l.s.r@web.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Brandon Williams" <bmwill@google.com>,
"Ben Peart" <Ben.Peart@microsoft.com>,
"Jeff Hostetler" <git@jeffhostetler.com>
Subject: Re: [PATCH 2/3] archive: implement protocol v2 archive command
Date: Fri, 14 Sep 2018 09:14:19 -0700 [thread overview]
Message-ID: <xmqq4lesdpk4.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180914060552.GD219147@aiede.svl.corp.google.com> (Jonathan Nieder's message of "Thu, 13 Sep 2018 23:05:52 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> I think though that instead of doing setlocale() it would be better to
>> pass some flag saying we're operating in a machine-readable mode, and
>> then we'd (as part of the protocol defintion) say we're going to emit
>> GIT_ERR_UPLOAD_ARCHIVE_EXPECTED_DELIM_PACKET or whatever.
>
> I think you're suggesting client-side message generation, and that is
> one way to handle internationalization of server output.
>
> The main downside is when the server really does want to provide a
> custom error message. For that, we'd need
>
> 1. To propagate LANG to the server, so it knows what human language
> to generate messages in.
>
> 2. On the server side, to produce messages in that language if
> available, with an appropriate fallback if not.
That is one way to do so, but it does not have to be the only way, I
would think. You can send a machine parsable message in pieces, and
assemble the parts of speech into a message at the receiving end.
Like sending a msgid to identify an entry in the .pot file, and
values to be filled in.
next prev parent reply other threads:[~2018-09-14 16:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 5:35 Add proto v2 archive command with HTTP support Josh Steadmon
2018-09-12 5:35 ` [PATCH 1/3] archive: use packet_reader for communications Josh Steadmon
2018-09-12 22:01 ` Stefan Beller
2018-09-13 14:58 ` Junio C Hamano
2018-09-13 15:34 ` Junio C Hamano
2018-09-12 5:35 ` [PATCH 2/3] archive: implement protocol v2 archive command Josh Steadmon
2018-09-12 22:28 ` Stefan Beller
2018-09-13 18:45 ` Ævar Arnfjörð Bjarmason
2018-09-14 6:05 ` Jonathan Nieder
2018-09-14 14:31 ` Ævar Arnfjörð Bjarmason
2018-09-14 16:14 ` Junio C Hamano [this message]
2018-09-14 16:19 ` Jonathan Nieder
2018-09-13 16:31 ` Junio C Hamano
2018-09-14 5:39 ` Jonathan Nieder
2018-09-12 5:35 ` [PATCH 3/3] archive: allow archive over HTTP(S) with proto v2 Josh Steadmon
2018-09-12 22:38 ` Stefan Beller
2018-09-13 16:47 ` Junio C Hamano
2018-09-27 20:28 ` Josh Steadmon
2018-09-14 5:57 ` Jonathan Nieder
2018-09-14 5:36 ` Add proto v2 archive command with HTTP support Jonathan Nieder
2018-09-27 1:24 ` [PATCH v2 0/4] " Josh Steadmon
2018-09-27 1:24 ` [PATCH v2 1/4] archive: follow test standards around assertions Josh Steadmon
2018-09-27 18:38 ` Stefan Beller
2018-09-27 1:24 ` [PATCH v2 2/4] archive: use packet_reader for communications Josh Steadmon
2018-09-27 18:42 ` Stefan Beller
2018-09-27 1:24 ` [PATCH v2 3/4] archive: implement protocol v2 archive command Josh Steadmon
2018-09-27 1:24 ` [PATCH v2 4/4] archive: allow archive over HTTP(S) with proto v2 Josh Steadmon
2018-09-27 18:20 ` [PATCH v2 0/4] Add proto v2 archive command with HTTP support Stefan Beller
2018-09-27 18:30 ` Jonathan Nieder
2018-09-27 22:20 ` Junio C Hamano
2018-09-27 22:33 ` Josh Steadmon
2018-09-28 1:25 ` Junio C Hamano
2018-09-27 18:30 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4lesdpk4.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Ben.Peart@microsoft.com \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=l.s.r@web.de \
--cc=sandals@crustytoothpaste.net \
--cc=sbeller@google.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).