git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Luke Diamand <luke@diamand.org>,
	git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Luke Diamand <ldiamand@roku.com>
Subject: Re: [PATCHv2] git-p4: ticket expiry test: use a fake p4 to avoid use of 'sleep'
Date: Sat, 09 Feb 2019 10:06:20 -0800	[thread overview]
Message-ID: <xmqq4l9ckfab.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190208201445.GB10587@szeder.dev> ("SZEDER Gábor"'s message of "Fri, 8 Feb 2019 21:14:45 +0100")

SZEDER Gábor <szeder.dev@gmail.com> writes:

> On Fri, Feb 08, 2019 at 07:02:31PM +0000, Luke Diamand wrote:
>> +# create a fake version of "p4" which returns a TicketExpiration based
>> +# on $EXPIRY, for testing login expiration
>> +create_fake_p4() {
>> +	(
>> +		cd "$git" && mkdir expire-p4 &&
>> +		cat >>expire-p4/p4 <<-EOF &&
>> +		#!/usr/bin/python
>
> I think this should be $PYTHON_PATH.

OK.

Luke, I think our mails / work crossed and the tip of 'master'
already has a removal.  Please make this into a separate patch that
adds (or, resurrects with an improved version) the test for the next
cycle.

Thanks.

  reply	other threads:[~2019-02-09 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 19:02 [PATCHv2] git-p4: ticket expiry test: use a fake p4 to avoid use of 'sleep' Luke Diamand
2019-02-08 20:14 ` SZEDER Gábor
2019-02-09 18:06   ` Junio C Hamano [this message]
2019-02-09 19:26     ` Luke Diamand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4l9ckfab.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=ldiamand@roku.com \
    --cc=luke@diamand.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).