From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by dcvr.yhbt.net (Postfix) with ESMTP id 5ACAC1F5AE
	for <e@yhbt.net>; Wed, 24 Jun 2020 16:12:38 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2404629AbgFXQMb (ORCPT <rfc822;e@yhbt.net>);
        Wed, 24 Jun 2020 12:12:31 -0400
Received: from pb-smtp2.pobox.com ([64.147.108.71]:61482 "EHLO
        pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2404235AbgFXQMa (ORCPT <rfc822;git@vger.kernel.org>);
        Wed, 24 Jun 2020 12:12:30 -0400
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id A707076863;
        Wed, 24 Jun 2020 12:12:28 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=cqU81TC5t8+RIu2Hx/lZ9/amA/M=; b=vcAAXc
        qentTt/ZqupQqj5Wm4O9MEuECks5xDVzcQ2TKj3Bc1H4dqs3hVwrGZbi2UAPwTpB
        XMz7pNH6KacAstHxzQH1QmFhLPo5cJq4/E1ChTes/eM628HuREisAK339PLB/xHw
        ItyUEJBakMRQSVSVDAu/b0deTzxxGf9XL+ojk=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=iU8CYEcfOY5LNZI6lQGzgl4WlNdpVKKO
        nrPylAIaZMeN2HK7gF0qi/4fHD17j22kN4aG1ezz8f58waMn1ORRGM6e00i1D9UQ
        piX7MMn5LPYWDk0xPWhkCqn9YNVk+MFU63A2U4HIT/E0ip5fKIejhIRoxODcrVhr
        LFBo7A8Lds4=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 9F04C76862;
        Wed, 24 Jun 2020 12:12:28 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [35.231.104.69])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 1D9E376860;
        Wed, 24 Jun 2020 12:12:28 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Derrick Stolee <stolee@gmail.com>
Cc:     Michael Forney <mforney@mforney.org>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] submodule: use submodule repository when preparing summary
References: <20200623205659.14297-1-mforney@mforney.org>
        <20200623205659.14297-2-mforney@mforney.org>
        <33de1078-5f19-e76c-2a30-1754494d1e31@gmail.com>
Date:   Wed, 24 Jun 2020 09:12:27 -0700
In-Reply-To: <33de1078-5f19-e76c-2a30-1754494d1e31@gmail.com> (Derrick
        Stolee's message of "Wed, 24 Jun 2020 10:35:30 -0400")
Message-ID: <xmqq4kr08mtw.fsf@gitster.c.googlers.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 7FC562DA-B635-11EA-82D1-D1361DBA3BAF-77302942!pb-smtp2.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Derrick Stolee <stolee@gmail.com> writes:

> Perhaps the test I requested in patch 1 is only appropriate
> here? Or, maybe the test should be test_expect_failure in the
> first patch and switched to test_expect_success here?

Either is OK, but it is probably easier to read to have just one
addition in 2/2 to expect succeses.  Temporarily revierting with
"git show ':!t' | git apply -R" before running test when you want
to reallly see how the original crashed is easy and simple enough.

Thanks.