From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Steve Kemp via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Steve Kemp <steve@steve.org.uk>
Subject: Re: [PATCH] comment: fix spelling mistakes inside comments
Date: Wed, 29 Jul 2020 11:16:46 -0700 [thread overview]
Message-ID: <xmqq4kpqb301.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <571792b3-e65b-e6e8-34b9-56a87a47de8d@gmail.com> (Derrick Stolee's message of "Wed, 29 Jul 2020 09:45:21 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> I'll leave it to more experienced contributors to comment on how a
> comment-only patch fits with this section Documentation/CodingGuidelines:
>
> - Fixing style violations while working on a real change as a
> preparatory clean-up step is good, but otherwise avoid useless code
> churn for the sake of conforming to the style.
>
> In my opinion, this change is not harmful, but also isn't super
> necessary. I could go either way.
Typofixes in comments has no chance of breaking things than a
carelessly done code churn made in the name of cleaning up, so
cost-benefit comparison is much more favourable. I'm sure that I
won't be exhausted after reviewing comment-only patch as much as
after reviewing code-churn only patch.
next prev parent reply other threads:[~2020-07-29 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 3:33 [PATCH] comment: fix spelling mistakes inside comments Steve Kemp via GitGitGadget
2020-07-29 13:45 ` Derrick Stolee
2020-07-29 18:12 ` Steve Kemp
2020-07-29 18:16 ` Junio C Hamano [this message]
2020-07-29 19:19 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kpqb301.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=steve@steve.org.uk \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).