From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org,
"Philippe Blain" <levraiphilippeblain@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH] completion: bash: support recursive aliases
Date: Mon, 09 Nov 2020 14:29:01 -0800 [thread overview]
Message-ID: <xmqq4klyb1w2.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <X6m8R9erSxGlPXq2@nand.local> (Taylor Blau's message of "Mon, 9 Nov 2020 17:01:43 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> I am not an expert or user of the Bash completion scripts in contrib, so
> I'll refrain from reviewing that portion of the patch.
>
> I would, however, recommend that you avoid the word 'recursive' here.
> Git rightly detects and rejects recursive and looping aliases. In fact,
> the example that you give below:
>
>> l = log --oneline
>> lg = l --graph
>
> Is not even recursive. I would instead recommend calling 'lg' a "nested"
> alias.
>
> You could argue about whether it is "l", "lg", or both that are nested,
> but I think renaming the patch to "completion: bash: support nested
> aliases" and then a s/recursive/nested throughout the patch message
> would be sufficient.
>
>> So the completion should detect such aliases as well.
Two comments.
- on design, is it possible to make a set of aliases that form a
cycle? do we need to worry about such case? what does the
current implementation do for an "alias" in such a cycle?
- on implementation, it is done as a recursive call to the same
function, but a loop that naturally maps tail recursion would
also be a trivial implementation. is it worth rewriting the
recursive calls into a loop? if we need to solve the circular
references (above) by say limiting the length of the cycle, would
such a rewrite make sense as a way to help implementation?
next prev parent reply other threads:[~2020-11-09 22:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 21:52 [PATCH] completion: bash: support recursive aliases Felipe Contreras
2020-11-09 22:01 ` Taylor Blau
2020-11-09 22:29 ` Junio C Hamano [this message]
2020-11-10 1:10 ` Felipe Contreras
2020-11-10 0:59 ` Felipe Contreras
2020-11-09 22:19 ` Jeff King
2020-11-10 1:06 ` Felipe Contreras
2020-11-10 1:19 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4klyb1w2.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=me@ttaylorr.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).