From: Junio C Hamano <gitster@pobox.com>
To: tboegi@web.de
Cc: git@vger.kernel.org, random_n0body@icloud.com,
levraiphilippeblain@gmail.com
Subject: Re: [PATCH v2 1/1] MacOS: precompose_argv_prefix()
Date: Fri, 29 Jan 2021 15:19:41 -0800 [thread overview]
Message-ID: <xmqq4kizs54i.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20210129171512.28167-1-tboegi@web.de> (tboegi@web.de's message of "Fri, 29 Jan 2021 18:15:12 +0100")
tboegi@web.de writes:
> Solution:
> precompose_argv() now handles the prefix (if needed), and is renamed into
> precompose_argv_prefix().
>
> Inside this function the config variable core.precomposeunicode is read
> into the global variable precomposed_unicode, as before.
> This reading is skipped if precomposed_unicode had been read before.
>
> The original patch for preocomposed unicode, 76759c7dff53, placed
> precompose_argv() into parse-options.c
> Now move it into git.c .
> As a cleanup, remove it from parse-options.c and diff*.c
So an effect of this change is that now everybody's argv[], not just
those who are using parse-options API, is munged at the same single
place. That sounds like a good move toward a happy future.
Will queue. Thanks.
next prev parent reply other threads:[~2021-01-29 23:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 11:35 git-bugreport-2021-01-06-1209.txt (git can't deal with special characters) Daniel Troger
2021-01-06 14:21 ` Torsten Bögershausen
2021-01-06 16:49 ` Daniel Troger
2021-01-06 21:47 ` Torsten Bögershausen
2021-01-06 22:21 ` Daniel Troger
2021-01-06 23:07 ` Randall S. Becker
2021-01-07 14:34 ` Philippe Blain
2021-01-07 15:49 ` Torsten Bögershausen
2021-01-07 16:21 ` Philippe Blain
2021-01-08 19:07 ` Torsten Bögershausen
2021-01-24 15:13 ` [PATCH/RFC v1 1/1] git restore -p . and precomposed unicode tboegi
2021-01-24 19:51 ` Junio C Hamano
2021-01-25 16:53 ` Torsten Bögershausen
2021-01-29 17:15 ` [PATCH v2 1/1] MacOS: precompose_argv_prefix() tboegi
2021-01-29 23:19 ` Junio C Hamano [this message]
2021-01-31 0:43 ` Junio C Hamano
2021-01-31 9:50 ` Torsten =?unknown-8bit?Q?B=C3=B6gershausen?=
2021-02-02 15:11 ` [PATCH v3 " tboegi
2021-02-02 17:43 ` Junio C Hamano
2021-02-03 16:28 ` [PATCH v4 " tboegi
2021-02-03 19:33 ` Junio C Hamano
2021-02-03 22:13 ` Junio C Hamano
2021-02-05 17:31 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kizs54i.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=random_n0body@icloud.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).