git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Dave Huseby" <dwh@linuxprogrammer.org>,
	"Lars Schneider" <larsxschneider@gmail.com>,
	"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH 2/3] SubmittingPatches: replace discussion of Travis with GitHub Actions
Date: Thu, 13 May 2021 07:40:13 +0900	[thread overview]
Message-ID: <xmqq4kf7fueq.fsf@gitster.g> (raw)
In-Reply-To: <patch-2.3-7add00cc87-20210512T084137Z-avarab@gmail.com> ("Ævar	Arnfjörð Bjarmason"'s message of "Wed, 12 May 2021 10:45:01 +0200")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> -If you have an account at GitHub (and you can get one for free to work
> -on open source projects), you can use their Travis CI integration to
> -test your changes on Linux, Mac (and hopefully soon Windows).  See
> -GitHub-Travis CI hints section for details.
> +If you have an account at GitHub pushing to a fork of
> +https://github.com/git/git will use their CI integration to test your
> +changes on Linux, Mac and Windows. See the GitHub CI section for details.

s/If you have an account at GitHub pushing/Pushing/

Whether pushing to a fork is possible is not even need to be said
with "If you have an account" here, as you begin the "GitHub CI"
section with "With an account at GitHub".

    Side note: I initially started to point out the lack of comma
    before "pushing", but after re-reading the paragraph, realized
    that the part before that missing comma is better left out.

> @@ -451,12 +450,12 @@ their trees themselves.
>    the status of various proposed changes.
>  
>  [[travis]]
> -== GitHub-Travis CI hints
> +== GitHub CI
>  
> -With an account at GitHub (you can get one for free to work on open
> -source projects), you can use Travis CI to test your changes on Linux,
> -Mac (and hopefully soon Windows).  You can find a successful example
> -test build here: https://travis-ci.org/git/git/builds/120473209
> +With an account at GitHub you can use GitHub CI to test your changes

Here, insert comma before "you can use".

> +on Linux, Mac and Windows. See
> +https://github.com/git/git/actions/workflows/main.yml for examples of
> +recent CI runs.

Thanks.

  parent reply	other threads:[~2021-05-12 23:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  8:44 [PATCH 0/3] SubmittingPatches: a few unrelated minor fixes Ævar Arnfjörð Bjarmason
2021-05-12  8:45 ` [PATCH 1/3] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-05-12  9:29   ` Felipe Contreras
2021-06-07 11:02     ` Ævar Arnfjörð Bjarmason
2021-06-07 16:16       ` Felipe Contreras
2021-05-12  8:45 ` [PATCH 2/3] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason
2021-05-12 12:24   ` Đoàn Trần Công Danh
2021-05-12 22:40   ` Junio C Hamano [this message]
2021-05-12  8:45 ` [PATCH 3/3] SubmittingPatches: remove pine-specific hints from MUA hints Ævar Arnfjörð Bjarmason
2021-05-12 23:51   ` Dave Huseby
2021-05-13  6:38     ` Felipe Contreras
2021-05-13 14:45       ` Dave Huseby
2021-05-13 20:08         ` Felipe Contreras
2021-05-17 19:05           ` Dave Huseby
2021-05-13  7:50     ` Ævar Arnfjörð Bjarmason
2021-05-13 14:42       ` Dave Huseby
2021-06-07 11:03 ` [PATCH v2 0/3] SubmittingPatches: a few unrelated minor fixes Ævar Arnfjörð Bjarmason
2021-06-07 11:03   ` [PATCH v2 1/3] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-06-07 15:58     ` Đoàn Trần Công Danh
2021-06-07 11:03   ` [PATCH v2 2/3] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason
2021-06-07 17:25     ` SZEDER Gábor
2021-06-07 11:03   ` [PATCH v2 3/3] SubmittingPatches: remove pine-specific hints from MUA hints Ævar Arnfjörð Bjarmason
2021-06-07 21:49     ` Johannes Schindelin
2021-06-08  3:50   ` [PATCH v2 0/3] SubmittingPatches: a few unrelated minor fixes Junio C Hamano
2021-07-22 12:11   ` [PATCH v3 0/2] SubmittingPatches: talk about GitHub CI, not Travis + move-only Ævar Arnfjörð Bjarmason
2021-07-22 12:11     ` [PATCH v3 1/2] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-07-23  6:36       ` Bagas Sanjaya
2021-07-22 12:11     ` [PATCH v3 2/2] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4kf7fueq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=congdanhqx@gmail.com \
    --cc=dwh@linuxprogrammer.org \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).