From: Junio C Hamano <gitster@pobox.com>
To: Fabian Stelzer <fs@gigacodes.de>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3 4/5] Use a better name for the function interpolating paths
Date: Tue, 27 Jul 2021 17:39:03 -0700 [thread overview]
Message-ID: <xmqq4kcfclw8.fsf@gitster.g> (raw)
In-Reply-To: <xmqq8s1rcn0t.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 27 Jul 2021 17:14:42 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Fabian Stelzer <fs@gigacodes.de> writes:
>>
>>>> I think Fabian's "ssh signing" is not as ready as this topic, and it
>>>> can afford to wait by rebasing on top of this topic. By the time
>>>> "ssh signing" gets into testable shape (right now, it does not pass
>>>> tests when merged to 'seen'), hopefully the "expand install-prefix"
>>>> topic may already be in 'next' if not in 'master'.
>>> I think the test problem is not due to my patch.
>>
>> I've been seeing these test failers locally, every time
>> fs/ssh-signing topic is merged to 'seen' (without the reftable
>> thing).
>>
>> Test Summary Report
>> -------------------
>> t5534-push-signed.sh (Wstat: 256 Tests: 13 Failed: 2)
>> Failed tests: 8, 12
>> Non-zero exit status: 1
>> t7528-signed-commit-ssh.sh (Wstat: 256 Tests: 23 Failed: 2)
>> Failed tests: 13, 17
>> Non-zero exit status: 1
>>
>> When reftable thing is merged, either compilation fails or t0031
>> fails, and I suspect that these are not due to the ssh signing
>> topic.
>
> Interesting. It seems that the failure has some correlation with
> the use of --root=<trash directory> option.
>
> $ sh t5534-push-signed.sh -i
And 7528 fails with --root set to a /dev/shm/ trash directory.
So,... this "principal with number #" differences come from the
differences in location of the trash directory? Why?
> --- expect 2021-07-28 00:11:20.863019887 +0000
> +++ dst/push-cert-status 2021-07-28 00:11:20.855019156 +0000
> @@ -1,4 +1,4 @@
> -SIGNER=principal with number 1
> +SIGNER=principal with number 3
> KEY=SHA256:Szd5rzYOrMBJFTR+gnRUu60YRVqg98UvpcSvmAm89rE
> STATUS=G
> NONCE_STATUS=OK
next prev parent reply other threads:[~2021-07-28 0:39 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 14:53 [PATCH 0/1] mingw: handle absolute paths in expand_user_path() Johannes Schindelin via GitGitGadget
2018-11-06 14:53 ` [PATCH 1/1] " Johannes Schindelin via GitGitGadget
2018-11-06 15:54 ` Ramsay Jones
2018-11-06 16:10 ` Ramsay Jones
2018-11-06 18:27 ` Duy Nguyen
2018-11-07 1:21 ` Junio C Hamano
2018-11-07 11:19 ` Johannes Schindelin
2018-11-07 17:42 ` Ramsay Jones
2018-11-08 0:16 ` Junio C Hamano
2018-11-08 13:04 ` Johannes Schindelin
2018-11-08 14:43 ` Junio C Hamano
2018-11-08 15:39 ` Johannes Schindelin
2018-11-09 2:05 ` Joseph Moisan
2018-11-09 10:21 ` Jeff King
2018-11-06 18:24 ` Duy Nguyen
2018-11-07 11:19 ` Johannes Schindelin
2018-11-06 21:32 ` Johannes Sixt
2018-11-07 11:23 ` Johannes Schindelin
2018-11-07 18:52 ` Johannes Sixt
2018-11-07 20:41 ` Jeff King
2018-11-07 21:36 ` Johannes Sixt
2018-11-07 22:03 ` Jeff King
2018-11-08 0:30 ` Junio C Hamano
2018-11-08 1:18 ` Jeff King
2018-11-08 3:26 ` Junio C Hamano
2018-11-08 13:11 ` Johannes Schindelin
2018-11-08 14:25 ` Duy Nguyen
2018-11-08 15:45 ` Johannes Schindelin
2018-11-08 17:40 ` Eric Sunshine
2018-11-09 10:19 ` Jeff King
2018-11-09 16:16 ` Duy Nguyen
2018-11-12 3:03 ` Junio C Hamano
2018-11-08 14:47 ` Junio C Hamano
2018-11-08 15:46 ` Johannes Schindelin
2021-07-01 16:03 ` [PATCH v2 0/2] " Johannes Schindelin via GitGitGadget
2021-07-01 16:03 ` [PATCH v2 1/2] tests: exercise the RUNTIME_PREFIX feature Johannes Schindelin via GitGitGadget
2021-07-01 16:03 ` [PATCH v2 2/2] expand_user_path(): support specifying paths relative to the runtime prefix Johannes Schindelin via GitGitGadget
2021-07-01 17:42 ` [PATCH v2 0/2] mingw: handle absolute paths in expand_user_path() Junio C Hamano
2021-07-24 22:06 ` [PATCH v3 0/5] " Johannes Schindelin via GitGitGadget
2021-07-24 22:06 ` [PATCH v3 1/5] tests: exercise the RUNTIME_PREFIX feature Johannes Schindelin via GitGitGadget
2021-07-24 22:06 ` [PATCH v3 2/5] expand_user_path(): remove stale part of the comment Johannes Schindelin via GitGitGadget
2021-07-24 22:06 ` [PATCH v3 3/5] expand_user_path(): clarify the role of the `real_home` parameter Johannes Schindelin via GitGitGadget
2021-07-24 22:06 ` [PATCH v3 4/5] Use a better name for the function interpolating paths Johannes Schindelin via GitGitGadget
2021-07-26 22:05 ` Junio C Hamano
2021-07-27 7:57 ` Fabian Stelzer
2021-07-27 22:56 ` Junio C Hamano
2021-07-28 0:14 ` Junio C Hamano
2021-07-28 0:39 ` Junio C Hamano [this message]
2021-07-28 5:43 ` Junio C Hamano
2021-07-28 8:18 ` Fabian Stelzer
2021-07-28 17:08 ` Junio C Hamano
2021-07-24 22:06 ` [PATCH v3 5/5] interpolate_path(): allow specifying paths relative to the runtime prefix Johannes Schindelin via GitGitGadget
2021-07-26 17:56 ` [PATCH v3 0/5] mingw: handle absolute paths in expand_user_path() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kcfclw8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).