git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Dr. Matthias St. Pierre" <Matthias.St.Pierre@ncp-e.com>,
	git@vger.kernel.org, Stefan Beller <stefanbeller@gmail.com>
Subject: Re: [PATCH] blame: document --color-* options
Date: Tue, 28 Sep 2021 09:22:06 -0700	[thread overview]
Message-ID: <xmqq4ka4n00h.fsf@gitster.g> (raw)
In-Reply-To: <fe78329d-07a7-bdf3-2bda-13def35f3de3@gmail.com> (Bagas Sanjaya's message of "Tue, 28 Sep 2021 12:43:13 +0700")

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 28/09/21 02.44, Junio C Hamano wrote:
>> Nowhere in "git blame --help" output we mention anything about
>> "metadata", so the readers of this new description will be left
>> puzzled what the word means in the context of this command.
>> We would need to pick words or phrases that readers can link easily
>> with the description of "THE PORCELAIN FORMAT" section.
>
> In git-blame(1), we only describe output format for "THE PORCELAIN
> FORMAT" as well as "INCREMENTAL OUTPUT", but not default format.
>
> On the other hand, --color-* options only works on default format, not
> the others.

Sorry for skipping a level of logical progression in the suggestion.

While I do not think we want to add another section for the default
format, if we were to add such a section, the new description should
use phrases that would have been used, and such a section would not
use a new and unclear "metadata" in the description.  Instead it
would use phrases that the users can look for elsewhere in the same
documentation.

What is colored is the summary of the commit the line came from
(abbreviated commit object name, plus the author name and time by
default) plus the line number, I think.

Thanks.

  parent reply	other threads:[~2021-09-28 16:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24 19:15 git-blame: '--color-by-age' option not documented in manual page Dr. Matthias St. Pierre
2021-09-25 12:18 ` [PATCH] blame: document --color-* options Bagas Sanjaya
2021-09-25 12:24   ` Bagas Sanjaya
2021-09-27 19:44   ` Junio C Hamano
2021-09-28  5:43     ` Bagas Sanjaya
2021-09-28 12:38       ` Dr. Matthias St. Pierre
2021-09-29  8:01         ` Bagas Sanjaya
2021-09-29  9:19           ` Dr. Matthias St. Pierre
2021-09-29  9:51         ` Bagas Sanjaya
2021-09-29 10:53           ` Dr. Matthias St. Pierre
2021-09-29 11:52             ` Dr. Matthias St. Pierre
2021-09-28 16:22       ` Junio C Hamano [this message]
2021-09-29  9:15         ` Bagas Sanjaya
2021-09-29 18:30           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4ka4n00h.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Matthias.St.Pierre@ncp-e.com \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=stefanbeller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).