From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0F0FC1F953 for ; Wed, 12 Jan 2022 18:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356293AbiALSfN (ORCPT ); Wed, 12 Jan 2022 13:35:13 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:62726 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356315AbiALSem (ORCPT ); Wed, 12 Jan 2022 13:34:42 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 126AB1151D8; Wed, 12 Jan 2022 13:34:42 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=Fun7uCHp8ujq H732lYzotihhLlMemvgw/2uDfTrs7vg=; b=QpCtqOyeVksI1MXpIoyvWh0joemf ndLghcBWEwhRF5sAcRMViIwRg0GtFmNq3Ig3J7u9XBwDB0Zpnf5ORntR8n6FBDaM 7niSxrsEDvMvGbHXOXeteKFiQhYbmxraMwnWQ/Sn4rwtoj+XE1i1xMwNsOCiJfdx rkrYqfhF1tXdBus= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 09DD71151D7; Wed, 12 Jan 2022 13:34:42 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 6EFB31151D6; Wed, 12 Jan 2022 13:34:41 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Phillip Wood via GitGitGadget" Cc: git@vger.kernel.org, Johannes Schindelin , SZEDER =?utf-8?Q?G=C3=A1bor?= , =?utf-8?B?w4Z2?= =?utf-8?B?YXIgQXJuZmrDtnLDsA==?= Bjarmason , Phillip Wood Subject: Re: [PATCH v2 0/2] builtin add -p: fix hunk splitting References: Date: Wed, 12 Jan 2022 10:34:40 -0800 In-Reply-To: (Phillip Wood via GitGitGadget's message of "Tue, 11 Jan 2022 11:12:08 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 4E40FD22-73D6-11EC-A1B1-CB998F0A682E-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Phillip Wood via GitGitGadget" writes: > Thanks to Junio and =C3=86var for their comments on V1. I've updated th= e commit > message and added a helper function as suggested. > > V1 Cover Letter: Fix a small regression in the hunk splitting of the bu= iltin > version compared to the perl version. Thanks to Szeder for the easy to > follow bug report. Looking good. After comparing the output from=20 $ git grep -e 'finalize[_a-z]*(' -e 'complete[_a-z]*(' \*.c I would have called the helper "finalize_file()", but in the context of this file, the name complete_file() is not misleading enough to require renaming. Will queue. Thanks.