From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-0.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B744F1F4D7 for ; Wed, 22 Jun 2022 05:52:24 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="vF9bHLaA"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357055AbiFVFwW (ORCPT ); Wed, 22 Jun 2022 01:52:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233358AbiFVFwT (ORCPT ); Wed, 22 Jun 2022 01:52:19 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6CDC36681 for ; Tue, 21 Jun 2022 22:52:18 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D491813C181; Wed, 22 Jun 2022 01:52:17 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=RMNbxku4iwIE nBalsSomwj4wSSA/mzVZp2Vz0bz1Wu0=; b=vF9bHLaAPy/c2RM9FdrMdkRJG/KU V2VVOvcRbABNrqaKHXdX42Dz5+v0zdDitTvk/XPUfXWOXbaGOfU9n65RYWteRITK qWQuWowpj8jQQkwMx47YSlw7Cs53mCBzH/Lg+GJdf//zVAFCcf2oRQ5HZRBMtijw KU2vEMDidF2pmQI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CA6A713C180; Wed, 22 Jun 2022 01:52:17 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id F21EC13C17F; Wed, 22 Jun 2022 01:52:16 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Derrick Stolee , rsbecker@nexbridge.com, SZEDER =?utf-8?Q?G=C3=A1bor?= , Johannes Sixt , Jeff King Subject: Re: [PATCH 01/10] fetch tests: remove redundant test_unconfig() References: Date: Tue, 21 Jun 2022 22:52:15 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 22 Jun 2022 00:34:13 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 78F009B8-F1EF-11EC-8F4D-5E84C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > The test_unconfig() calls here were added as boilerplate in > 737c5a9cde7 (fetch: make --prune configurable, 2013-07-13), and then > faithfully reproduced in e249ce0ccdb (fetch tests: add scaffolding for > the new fetch.pruneTags, 2018-02-09). But they were never necessary, unnecessary because ...? is it because nothing has happened in this directory before? is it because these will all be overriden by the command line options? is it because of something else? > so let's remove them. > This actually improves our test coverage, as we'll now be asserting > that whatever configuration we leave here (in the "one" block below) > won't affect this particular "git fetch" command. > > Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > --- > t/t5510-fetch.sh | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh > index 4620f0ca7fa..d784a761ba0 100755 > --- a/t/t5510-fetch.sh > +++ b/t/t5510-fetch.sh > @@ -874,10 +874,6 @@ test_configured_prune_type () { > git tag -f newtag && > ( > cd one && > - test_unconfig fetch.prune && > - test_unconfig fetch.pruneTags && > - test_unconfig remote.origin.prune && > - test_unconfig remote.origin.pruneTags && > git fetch '"$cmdline_setup"' && > git rev-parse --verify refs/remotes/origin/newbranch && > git rev-parse --verify refs/tags/newtag