From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 5EBB21F506 for ; Mon, 19 Sep 2022 21:38:19 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="ZwJX/jxQ"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiISViK (ORCPT ); Mon, 19 Sep 2022 17:38:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiISVhl (ORCPT ); Mon, 19 Sep 2022 17:37:41 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D299440E27 for ; Mon, 19 Sep 2022 14:37:35 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id B87A5142179; Mon, 19 Sep 2022 17:37:34 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=dGF/uwnNfkHb5+PvEyHHpinKxyOuJzl+Oq6WfH zprGA=; b=ZwJX/jxQjhMZ61fC+kMH9PKt+gzZTf0TVglttYEKfe75D3naeR2mfF XLGY49ORZK0NYFA5wT5VVM6AuWddiPp0x6w5qeL9x3e4cgPn0cqGrNDBNJV4tZsf jVUmUVnDgf4hVnRIyussUmf2u0/7R9KuuI68fdXrmRlPFqoO+xdfk= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id AF6CE142178; Mon, 19 Sep 2022 17:37:34 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 10E6E142177; Mon, 19 Sep 2022 17:37:34 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Victoria Dye via GitGitGadget" Cc: git@vger.kernel.org, derrickstolee@github.com, Johannes.Schindelin@gmx.de, steadmon@google.com, chooglen@google.com, Victoria Dye Subject: Re: [PATCH v2] Documentation: add ReviewingGuidelines References: Date: Mon, 19 Sep 2022 14:37:33 -0700 In-Reply-To: (Victoria Dye via GitGitGadget's message of "Mon, 19 Sep 2022 19:12:46 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 45B7567C-3863-11ED-9CCC-307A8E0A682E-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Victoria Dye via GitGitGadget" writes: > From: Victoria Dye > > Add a reviewing guidelines document including advice and common terminology > used in Git mailing list reviews. The document is included in the > 'TECH_DOCS' list in order to include it in Git's published documentation. > > Helped-by: Johannes Schindelin > Helped-by: Derrick Stolee > Helped-by: Junio C Hamano > Helped-by: Josh Steadmon > Signed-off-by: Victoria Dye > --- > Documentation: add ReviewingGuidelines > > This patch follows up on a discussion a few weeks ago in the Git IRC > standup [1], where it was mentioned that it would be nice to have > consistent definitions for common review terminology (like 'nit:'). The > "ReviewingGuidelines" document created here builds on that idea, as well > as past discussions around the idea of advice for reviewers (similar to > the guidelines for new contributors in MyFirstContribution [2]). Thanks. Will queue. I think this is ready for 'next' and then to 'master' during this cycle. Thanks for writing it, and thanks all for reviewing it.